Add migration waiting script and log cleaner #8219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Apr 8, 2020
dimberman
force-pushed
the
add-migration-wait-script
branch
from
85a85ed to
a8c8950
Compare
ashb
reviewed
Apr 8, 2020
dimberman
force-pushed
the
add-migration-wait-script
branch
from
a8c8950 to
ab7faa8
Compare
dimberman
changed the title
dimberman
changed the title
dimberman
force-pushed
the
add-migration-wait-script
branch
from
2fae38d to
35a8d8f
Compare
dimberman
force-pushed
the
add-migration-wait-script
branch
4 times, most recently
from
9a8290c to
c0d2191
Compare
Contributor
Author
|
@ashb changing that "and v" in the argument parsing broke a lot of things in non-trivial ways. I think if we want to fix how we parse commands that should be its own ticket. |
dimberman
force-pushed
the
add-migration-wait-script
branch
from
4fbd7f5 to
8a08498
Compare
Codecov Report
@@ Coverage Diff @@
## master #8219 +/- ##
===========================================
- Coverage 88.43% 33.45% -54.99%
===========================================
Files 940 940
Lines 45354 45381 +27
===========================================
- Hits 40109 15182 -24927
- Misses 5245 30199 +24954
Continue to review full report at Codecov.
|
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
reviewed
Apr 15, 2020
ashb
previously requested changes
Apr 15, 2020
dimberman
force-pushed
the
add-migration-wait-script
branch
3 times, most recently
from
58743e0 to
56d50dc
Compare
dimberman
force-pushed
the
add-migration-wait-script
branch
from
470a097 to
07203d9
Compare
5 tasks
kaxil
approved these changes
Apr 15, 2020
This PR creates a "migration spinner" that allows the webserver to wait for all database migrations to complete before starting up. Is a necessary component before we can merge the helm chart.
dimberman
force-pushed
the
add-migration-wait-script
branch
from
07203d9 to
797d737
Compare
turbaszek
reviewed
Apr 16, 2020
Co-Authored-By: Tomek Urbaszek <[email protected]>
5 tasks
ashb
added a commit
to ashb/airflow
that referenced
this pull request
Apr 16, 2020
In apache#8219 we noticed that we couldn't set a `default=0` because of the `and v` check. The "add_argument" function in python avoid this by using **kwargs, but we want type checking so can't directly use the same there. This uses the same pattern that configparser does to allow falsey (0, False) and even `None` as valid values, distinct from not being passed.
ashb
added a commit
that referenced
this pull request
Apr 16, 2020
In #8219 we noticed that we couldn't set a `default=0` because of the `and v` check. The "add_argument" function in python avoid this by using **kwargs, but we want type checking so can't directly use the same there. This uses the same pattern that configparser does to allow falsey (0, False) and even `None` as valid values, distinct from not being passed.
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 17, 2020
It wasn't added until apache#8219, which isn't yet in any release. This approach is VERY not pretty, but if we want to support Airflow 1.10.10, and not require any changes or external binary in the image, then this is the only thing I can think of (For instance, we could say "pip install https://github.com/astronomer/astronomer-airflow-scripts" if you want to use this on <1.10.11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a "migration spinner" that allows the webserver to wait for all database migrations to complete before starting up. Is a necessary component before we can merge the helm chart.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.