Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Apr 8, 2020

This reverts commit 11f1e0c.

The OpenAPI spec as added in has problems and needs revisiting (typos,
wrong IDs, wrong types). Sorry to do this, but

  1. PR Add OpenAPI spec #7549 never had any approval, and the AIP never linked to that PR. (1b. AIP vote passing does not equal PR approval. Every PR still needs approval. AIP vote is not code review.)
  2. It has the mistakes that you said you fixed in the AIP were not fixed.
  3. There are open questions around the IDs we use.
  4. All the typos that were left as a comment on the polidea PR before you merged this PR.

Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ashb ashb requested review from mik-laj and potiuk April 8, 2020 16:32
@ashb
Copy link
Member Author

ashb commented Apr 8, 2020

See also the mailing list post I'm about to start about the id types for connection and Dag Run.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. The PR had no approvals it is NotCool indeed.

This reverts commit 11f1e0c.

The OpenAPI spec as added in has problems and needs revisiting (typos,
wrong IDs, wrong types)
@ashb ashb force-pushed the remove-unreviewd-openapi-spec branch from 8f40890 to 04f232d Compare April 8, 2020 19:09
@ashb ashb merged commit 9468187 into apache:master Apr 8, 2020
@ashb ashb deleted the remove-unreviewd-openapi-spec branch April 8, 2020 23:03
@mik-laj mik-laj mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants