Repository navigation
Conversation
AirflowConsole.print_as_table passed column headers and cell values to Rich without escaping. Consequently, values or column headers containing Rich closing tags such as [/b] crashed the CLI with a MarkupError, and strings containing bracketed text such as s3://[bucket]/path or [tag] silently had their bracketed sections stripped. Escape headers and cell values with rich.markup.escape so they render literally as stored, matching the behavior in airflow-ctl.
Kaap10
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
November 5, 2026 05:59
yuseok89
reviewed
Nov 6, 2026
yuseok89
left a comment
yuseok89
left a comment
Contributor
There was a problem hiding this comment.
I left one small suggestion.
Co-authored-by: Yuseok Jo <[email protected]>
Contributor
Author
|
Thanks @yuseok89 for the suggestion! Applied, and all CI checks are now fully green. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AirflowConsole.print_as_tableandprint_as_plain_tableinairflow-core/src/airflow/cli/simple_table.pypassed column headers and cell values to Rich without escaping. Consequently, values or column headers containing Rich closing tags such as[/b]crashed the CLI command with aMarkupError, and strings containing bracketed text such ass3://[bucket]/pathor[tag]silently had their bracketed sections stripped.This change escapes column headers and cell values with
rich.markup.escapeinprint_as_tableand renders literal plain text inprint_as_plain_tablewithmarkup=False, matching the behavior established inairflowctl(PR #76175). Dedicated unit tests are added inairflow-core/tests/unit/cli/test_simple_table.py.Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines