Repository navigation
[airflow-ctl/v0-1-test] Show square brackets in airflowctl table and plain output as typed (#76175) - #76205
Merged
shahar1 merged 1 commit intoNov 1, 2026
Conversation
…plain output as typed (#76175) * Show square brackets in airflowctl table and plain output as typed `airflowctl ... --output table` and `--output plain` passed values to Rich as markup, so a value such as `[/b]` crashed the command with a MarkupError and a value such as `s3://[bucket]/path` silently lost its bracketed part. Render the values literally, as `--output json` and `--output yaml` already do. * Show square brackets in airflowctl table headers as typed Column headers were still passed to Rich as markup, so a key such as `[/b]` raised a MarkupError and `[red]name[/red]` lost its tags in `--output table`. Escape them like the cell values, and run the output tests once per value, including a backslash before a tag. --------- (cherry picked from commit 117f115) Co-authored-by: Rishabh <[email protected]> Co-authored-by: Shahar Epstein <[email protected]>
shahar1
marked this pull request as ready for review
November 1, 2026 11:14
shahar1
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
November 1, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflowctl ... --output tableand--output plainpassed values to Richas markup, so a value such as
[/b]crashed the command with aMarkupError and a value such as
s3://[bucket]/pathsilently lost itsbracketed part. Render the values literally, as
--output jsonand--output yamlalready do.Column headers were still passed to Rich as markup, so a key such as
[/b]raised a MarkupError and[red]name[/red]lost its tags in--output table. Escape them like the cell values, and run the outputtests once per value, including a backslash before a tag.
(cherry picked from commit 117f115)
Co-authored-by: Rishabh [email protected]
Co-authored-by: Shahar Epstein [email protected]