Repository navigation
Conversation
`airflowctl ... --output table` and `--output plain` passed values to Rich as markup, so a value such as `[/b]` crashed the command with a MarkupError and a value such as `s3://[bucket]/path` silently lost its bracketed part. Render the values literally, as `--output json` and `--output yaml` already do.
Rishabh00b
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
October 31, 2026 19:43
Rishabh00b
marked this pull request as draft
October 31, 2026 19:45
Rishabh00b
marked this pull request as ready for review
October 31, 2026 19:50
Column headers were still passed to Rich as markup, so a key such as `[/b]` raised a MarkupError and `[red]name[/red]` lost its tags in `--output table`. Escape them like the cell values, and run the output tests once per value, including a backslash before a tag.
github-actions
Bot
added
need workflow approval
and removed
need workflow approval
labels
Contributor
|
Merged from main to include the CI fix |
potiuk
approved these changes
Nov 1, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Thanks — escape for the Rich table and markup=False for the already-formatted plain output is the right split, and the tests cover the crash ([/b]) and the silent loss (s3://[bucket]/path) in both values and headers.
This review was drafted by an AI-assisted tool and
confirmed by an Apache Airflow maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Airflow handles maintainer review:
Contributing guide.
potiuk
enabled auto-merge (squash)
November 1, 2026 09:13
Contributor
Backport successfully created: airflow-ctl/v0-1-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
shahar1
added a commit
that referenced
this pull request
Nov 1, 2026
…plain output as typed (#76175) (#76205) * Show square brackets in airflowctl table and plain output as typed `airflowctl ... --output table` and `--output plain` passed values to Rich as markup, so a value such as `[/b]` crashed the command with a MarkupError and a value such as `s3://[bucket]/path` silently lost its bracketed part. Render the values literally, as `--output json` and `--output yaml` already do. * Show square brackets in airflowctl table headers as typed Column headers were still passed to Rich as markup, so a key such as `[/b]` raised a MarkupError and `[red]name[/red]` lost its tags in `--output table`. Escape them like the cell values, and run the output tests once per value, including a backslash before a tag. --------- (cherry picked from commit 117f115) Co-authored-by: Rishabh <[email protected]> Co-authored-by: Shahar Epstein <[email protected]>
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflowctl ... --output tableand--output plainpassed values to Rich as markup, so a value such as[/b]crashed the command with a MarkupError and a value such ass3://[bucket]/pathsilently printed ass3:///path. Render the values literally, as--output jsonand--output yamlalready do.Two new tests in
test_console_formatting.pyfail without this change and pass with it. The full airflow-ctl test suite passes locally.