Repository navigation
Add unit tests for auth manager login datamodels (#72265) - #75544
Merged
vincbeck merged 3 commits intoOct 28, 2026
Merged
Conversation
- Add test_login.py for amazon auth_manager datamodels - Add test_login.py for fab auth_manager datamodels - Remove both from OVERLOOKED_TESTS in test_project_structure.py
boring-cyborg
Bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Oct 26, 2026
vincbeck
enabled auto-merge (squash)
October 26, 2026 14:35
auto-merge was automatically disabled
October 26, 2026 16:04
Head branch was pushed to by a user without write access
vincbeck
enabled auto-merge (squash)
October 26, 2026 17:04
…_0_PLUS Skip auth manager login datamodel tests on Airflow < 3.0.0 where airflow.api_fastapi is not available, fixing Compat 2.11.1 failure.
auto-merge was automatically disabled
October 26, 2026 18:27
Head branch was pushed to by a user without write access
vincbeck
enabled auto-merge (squash)
October 26, 2026 23:20
Contributor
Author
|
Note for committers: The lone failure in Compat 3.0.6:P3.11:amazon...google is an infrastructure flake (TimeoutError: mongod at 172.17.0.1:32768 did not answer ping within 60s in providers/mongo/tests/unit/mongo/hooks/test_mongo.py). All 5,302 Amazon provider tests in that job passed cleanly. Ready for rerun or merge. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #72265.
Adds missing unit tests for auth manager login datamodels:
airflow.providers.amazon.aws.auth_manager.datamodels.login.LoginResponse(valid construction, dict validation, and required field enforcement)airflow.providers.fab.auth_manager.api_fastapi.datamodels.login.LoginResponse(valid construction, dict validation, and required field enforcement)OVERLOOKED_TESTSinairflow-core/tests/unit/always/test_project_structure.py.Use case/motivation
Improves provider test completeness for FastAPI auth manager endpoints and reduces
OVERLOOKED_TESTS.Related Issues
Closes: #72265
Checklist