Repository navigation
[v3-4-test] Scope upstream asset events of a Dag run to assets and Dags the caller may read (#72924) - #75108
Merged
Conversation
…gs the caller may read (#72924) GET /dags/{dag_id}/dagRuns/{dag_run_id}/upstreamAssetEvents returned every asset event a run consumed as long as the caller could read the consuming Dag. Events of assets, or produced by source Dags, the caller is not allowed to read were exposed, including their name, uri, extra and source Dag/task ids, even though GET /assets/events hides the same events. Query the consumed events through the dagrun_asset_event table and apply the same per-asset and per-source-Dag readability filters as GET /assets/events, so hidden events are excluded from both the response and total_entries. (cherry picked from commit 6f408e1) Co-authored-by: Henry Chen <[email protected]>
1 task done
potiuk
marked this pull request as ready for review
October 19, 2026 20:19
potiuk
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun and
rawwar
as code owners
October 19, 2026 20:19
potiuk
requested review from
choo121600,
henry3260 and
shubhamraj-git
as code owners
October 19, 2026 20:19
1 task done
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…gs the caller may read (#72924) (#75108) * [v3-4-test] Scope upstream asset events of a Dag run to assets and Dags the caller may read (#72924) GET /dags/{dag_id}/dagRuns/{dag_run_id}/upstreamAssetEvents returned every asset event a run consumed as long as the caller could read the consuming Dag. Events of assets, or produced by source Dags, the caller is not allowed to read were exposed, including their name, uri, extra and source Dag/task ids, even though GET /assets/events hides the same events. Query the consumed events through the dagrun_asset_event table and apply the same per-asset and per-source-Dag readability filters as GET /assets/events, so hidden events are excluded from both the response and total_entries. (cherry picked from commit 6f408e1) Co-authored-by: Henry Chen <[email protected]> * Mock the simple auth manager in the upstream asset events permission test (#75126) SimpleAuthManager overrides get_authorized_assets since #72934, so patching the BaseAuthManager method left the real one in place, every asset stayed readable, and the test added in #72924 failed on main. Generated-by: Claude Opus 5 (cherry picked from commit 33e6b5f) --------- Co-authored-by: Henry Chen <[email protected]> Co-authored-by: Jarek Potiuk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /dags/{dag_id}/dagRuns/{dag_run_id}/upstreamAssetEvents returned every
asset event a run consumed as long as the caller could read the consuming Dag.
Events of assets, or produced by source Dags, the caller is not allowed to read
were exposed, including their name, uri, extra and source Dag/task ids, even
though GET /assets/events hides the same events.
Query the consumed events through the dagrun_asset_event table and apply the
same per-asset and per-source-Dag readability filters as GET /assets/events,
so hidden events are excluded from both the response and total_entries.
(cherry picked from commit 6f408e1)
Co-authored-by: Henry Chen [email protected]