Repository navigation
Conversation
Unexpected sensor errors should remain visible regardless of whether the sensor defers. Treating missing resources and trigger failures as skips hides operational failures, while uncaught task timeouts ignore the configured failure policy.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deferred sensors with
soft_fail=Truecurrently turn unexpected errors into skips, hiding missing resources and trigger failures. Preserve these errors on resume and applysoft_failto the same exception types as the regular sensor execution path:AirflowSensorTimeout,AirflowTaskTimeout, andAirflowFailException.Also catch
AirflowTaskTimeouton resume so bothsoft_failandnever_failcan convert it to a skip. This extendsnever_failhandling for task timeouts; its handling of other errors is unchanged.Validation:
9ad8d78c27(Python 3.11, Breeze).7a479a62e6: 5 failed, 47 passed. Failures cover generic errors, missing resources, trigger failure, and task timeouts under both flags.This follows the behavior discussed in the closed, unmerged PR #72053. Full worker/triggerer integration has not been tested.
closes: #71255
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-6) following the guidelines