Repository navigation
[v3-4-test] Do not abort Dag run creation when a deadline alert fails (#68917) - #74975
Merged
Merged
Conversation
…#68917) * Do not abort Dag run creation when a deadline alert fails Deadline alerts are an observability feature layered on top of a Dag run, so they must never be able to stop one from existing. Decoding a stored alert, resolving its interval and evaluating its reference all happen inside create_dagrun, and any of them could raise straight out through Dag run creation -- so one malformed or unresolvable alert took the whole Dag run down with it, and on a Dag with several alerts the first failure starved the rest of their deadlines. The new deadline_alerts.deadline_creation_failed counter keeps these skips visible rather than silent. (cherry picked from commit f792bd6) Co-authored-by: Sean Ghaeli <[email protected]>
1 task done
vatsrahul1001
marked this pull request as ready for review
October 18, 2026 09:02
vatsrahul1001
requested review from
amoghrajesh,
ashb,
bolkedebruin and
potiuk
as code owners
October 18, 2026 09:02
vatsrahul1001
approved these changes
Oct 18, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 20, 2026
…#68917) (#74975) * Do not abort Dag run creation when a deadline alert fails Deadline alerts are an observability feature layered on top of a Dag run, so they must never be able to stop one from existing. Decoding a stored alert, resolving its interval and evaluating its reference all happen inside create_dagrun, and any of them could raise straight out through Dag run creation -- so one malformed or unresolvable alert took the whole Dag run down with it, and on a Dag with several alerts the first failure starved the rest of their deadlines. The new deadline_alerts.deadline_creation_failed counter keeps these skips visible rather than silent. (cherry picked from commit f792bd6) Co-authored-by: Sean Ghaeli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deadline alerts are an observability feature layered on top of a Dag run, so
they must never be able to stop one from existing. Decoding a stored alert,
resolving its interval and evaluating its reference all happen inside
create_dagrun, and any of them could raise straight out through Dag run
creation -- so one malformed or unresolvable alert took the whole Dag run down
with it, and on a Dag with several alerts the first failure starved the rest of
their deadlines.
The new deadline_alerts.deadline_creation_failed counter keeps these skips
visible rather than silent.
(cherry picked from commit f792bd6)
Co-authored-by: Sean Ghaeli [email protected]