Repository navigation
Make the SRV test fixture reset dns package attributes - #73659
Merged
Merged
Conversation
stable_dns_import was meant to stop the SRV tests hitting real DNS when
another test's patch.dict(sys.modules, ...) leaves the dns package
attribute and sys.modules["dns.resolver"] pointing at different module
objects. It only re-imported the submodules, which is a no-op when they
are already in sys.modules, so the mismatch survived. On Python 3.11+
mock.patch("dns.resolver.resolve") patches the sys.modules copy while
the hook's `import dns.resolver` reads the package attribute, so
test_resolve_srv_targets_orders_by_priority made a real SRV query and
failed. The fixture now points dns.exception, dns.resolver and
dns.asyncresolver on the package at the modules in sys.modules.
Generated-by: Claude Opus 5
vatsrahul1001
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stable_dns_import was meant to stop the SRV tests hitting real DNS when
another test's patch.dict(sys.modules, ...) leaves the dns package
attribute and sys.modules["dns.resolver"] pointing at different module
objects. It only re-imported the submodules, which is a no-op when they
are already in sys.modules, so the mismatch survived. On Python 3.11+
mock.patch("dns.resolver.resolve") patches the sys.modules copy while
the hook's
import dns.resolverreads the package attribute, sotest_resolve_srv_targets_orders_by_priority made a real SRV query and
failed. The fixture now points dns.exception, dns.resolver and
dns.asyncresolver on the package at the modules in sys.modules.
🤖 Generated with Claude Code