Repository navigation
Make test_trigger_lifecycle deterministic instead of timing-based - #73397
Merged
Merged
Conversation
The test forked the real trigger runner and gave it a single 0.1 s select window to check in before asserting that the trigger was running. On slow or loaded CI hosts (seen on the MySQL core job) the child had not sent its first state sync yet and the assertion failed. The deletion half already polled with a 10 s deadline, which only widens the same race instead of removing it. Both halves of the triggerer now live in the test process, joined by a small comms bridge that pushes each runner request through the supervisor's real frame decode, request handling and response encode. The test drives the same calls TriggerRunner.arun makes per iteration and waits on the trigger coroutine itself rather than the clock, so the outcome no longer depends on scheduling speed.
potiuk
approved these changes
Sep 22, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #60754
AI Summary
The test forked the real trigger runner and gave it a single 0.1 s select window to check in before asserting that the trigger was running. On slow or loaded CI hosts (seen on the MySQL core job) the child had not sent its first state sync yet and the assertion failed. The deletion half already polled with a 10 s deadline, which only widens the same race instead of removing it.
Both halves of the triggerer now live in the test process, joined by a small comms bridge that pushes each runner request through the supervisor's real frame decode, request handling and response encode. The test drives the same calls TriggerRunner.arun makes per iteration and waits on the trigger coroutine itself rather than the clock, so the outcome no longer depends on scheduling speed.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.