Skip to content

Fail the local yml mounts prek hook when synchronization fails - #73170

Closed
rjgoyln wants to merge 1 commit into
apache:mainfrom
rjgoyln:fix/prek-local-yml-mounts-exit-code
Closed

rjgoyln wants to merge 1 commit into
apache:mainfrom
rjgoyln:fix/prek-local-yml-mounts-exit-code

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

update-local-yml-file printed a red error and exited zero when breeze setup synchronize-local-mounts failed, so the hook reported green on a failed synchronization and left the generated volume list in scripts/ci/docker_compose/local.yml stale.

  • Exit with the command's return code instead of only printing, as the other hooks in scripts/ci/prek/ do.
  • Cover the exit code with a test that runs the real script against a stubbed breeze.

Two existing guards narrow the silent path without closing it: prek's own "files were modified by this hook" check catches a synchronization that succeeds and rewrites the file, and initialize_breeze_prek already exits 1 when breeze is not on PATH. What remains is a breeze run that fails — most likely a broken docker_command_utils.py, which both triggers this hook and supplies the mount list the command reads.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

The hook printed a red error and exited zero, so a failed synchronization
passed as green and left the generated mounts in local.yml stale. The
failure it is most likely to hide is a broken docker_command_utils.py,
which is one of the two files that trigger the hook in the first place.
@rjgoyln
rjgoyln marked this pull request as ready for review September 15, 2026 11:55
@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @rjgoyln - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 24 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants