[AIRFLOW-6699] Parameterize weekday sensor tests #7316
Conversation
|
Note: I noticed usage of |
coopergillan
force-pushed
the
AIRFLOW-6699-parameterize-weekday-tests-in-unittest
branch
2 times, most recently
from
c33c47e to
6aa82b4
Compare
Using the parameterized library, consolidate the true or "happy path" tests, reducing overall code to maintain and showing each test case in one list of tuples.
coopergillan
force-pushed
the
AIRFLOW-6699-parameterize-weekday-tests-in-unittest
branch
from
f3e4aa4 to
2fecab1
Compare
|
Pushed up two fixup commits and then squashed them into one. |
Codecov Report
@@ Coverage Diff @@
## master #7316 +/- ##
==========================================
+ Coverage 85.82% 85.96% +0.14%
==========================================
Files 863 866 +3
Lines 40484 41420 +936
==========================================
+ Hits 34744 35608 +864
- Misses 5740 5812 +72
Continue to review full report at Codecov.
|
|
@coopergillan I see that you like order in tests. Wouldn't you like to organize one file? |
|
Sure, I would love to give that a shot. Thanks!
On Fri, Jan 31, 2020 at 16:53 Kamil Breguła ***@***.***> wrote:
@coopergillan <https://github.com/coopergillan> I see that you like order
in tests. Wouldn't you like to organize one file?
https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
This file contains tests for many unrelated components. I think it would
be useful to transfer some tests to other files.
Here is an example: ***@***.***
<PolideaInternal@a91b612>
To avoid conflicts you can do it in one PR, but it would be useful for
each move to be in a separate commit. This will facilitate the review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7316?email_source=notifications&email_token=ACSELCXBOLPFPD3ENLHDQOLRASTU3A5CNFSM4KONYK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQIR4Q#issuecomment-580946162>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACSELCQ5GLIHM547JBRVIXDRASTU3ANCNFSM4KONYK7Q>
.
--
Cooper
|
|
@mik-laj - is there already an Apache JIRA ticket for reorganizing those Hive tests? If not, I am happy to create one. |
coopergillan
deleted the
AIRFLOW-6699-parameterize-weekday-tests-in-unittest
branch
|
@coopergillan Not yet. You must create a new ticket. |
|
Let me know if that is accurate based on what you mentioned. |
|
@mik-laj - I did start some of that work on organizing the Hive tests. Here is what I have so far: Do you think this is the right idea? Would love any other feedback on that. Thanks! |
Using the parameterized library, consolidate the true or "happy path" tests, reducing overall code to maintain and showing each test case in one list of tuples.
3 participants
Using the
parameterizedlibrary, consolidate the "true" or so-called "happy path" tests, reducing overall code to maintain and showing each test case in one list of tuples.This makes it faster to add any other true test cases if need be.
For now, the "false" tests are different enough to remain as-is.
Issue link: AIRFLOW-6699
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.