Repository navigation
Log the HTTP response in HttpToS3Operator when log_response is set - #72951
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <[email protected]>
boring-cyborg
Bot
added
area:providers
provider:amazon
7 of 12 tasks
Contributor
Author
|
@vincbeck @o-nikolas this has been sitting with green CI for five days. It is a two-line fix for a documented option that is never read, found by the audit in #72982. Could one of you take a look when you have a moment? Thanks. |
vincbeck
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpToS3Operatordocumentslog_response("Log the response (default: False)") and stores it, butexecute()never reads it, so the response body is never logged no matter what the user sets. This logsresponse.textafter the request when the flag is set, the same wayHttpOperatordoes.Changes
providers/amazon/src/airflow/providers/amazon/aws/transfers/http_to_s3.py: log the response text whenlog_responseis trueproviders/amazon/tests/unit/amazon/aws/transfers/test_http_to_s3.py:test_execute_logs_response_only_when_requested, parametrized over both valuesTesting
providers/amazon:tests/unit/amazon/aws/transfers/test_http_to_s3.pyWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Fable 5.1) following the guidelines. I reviewed and understand all changes; the tests were run locally as listed above.
🤖 Generated with Claude Code