Skip to content

Add Stats.observable_gauge for callback-based OTel gauges - #72887

Closed
Kunal8954 wants to merge 2 commits into
apache:mainfrom
Kunal8954:issue-72885-observable-gauge
Closed

Kunal8954 wants to merge 2 commits into
apache:mainfrom
Kunal8954:issue-72885-observable-gauge

Conversation

@Kunal8954

Copy link
Copy Markdown
Contributor

Add a callback-based Stats.observable_gauge(name, callback, description=...) API to the Stats observability interface. Instead of a caller pushing a value at a moment in time (the existing Stats.gauge), a callback is registered once and the metrics SDK invokes it on its own export/collection cadence, guaranteeing a fresh "current state" sample every collection cycle.

Implemented in the OpenTelemetry backend (SafeOtelLogger) via create_observable_gauge: the user callback receives the collection timeout and yields (value, attributes) tuples, which are converted to OTel Observation objects internally. Callback exceptions are handled by the OTel SDK (logged, do not crash collection). Stats.gauge and all other existing Stats methods are unchanged and fully backward compatible.

On non-OTel backends (StatsD, Datadog) and when no backend is configured, observable_gauge is a silent no-op — those backends do not support observable instruments. The prek metrics-registry hook is updated to classify observable_gauge as type gauge.

Validation:

  • OTel backend tests: 7 new (registration, callback invocation, exception propagation, invalid/empty names, empty callback, timeout forwarding) — all pass
  • Stats facade/StatsD/Datadog tests: 5 new (delegation via module + Stats class, description passthrough, no-op behavior) — all pass
  • prek registry hook tests: 106 pass
  • ruff, mypy, git diff --check: clean

closes: #72885


Was generative AI tooling used to co-author this PR?
  • Yes — big-pickle

Generated-by: big-pickle following the guidelines

@Kunal8954

Kunal8954 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Hy @jason810496
can you review the pr and then merge it?

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Kunal8954 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 8 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk potiuk closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stats interface: support asynchronous/observable gauge metrics

2 participants