Skip to content

Clear the task state store when clearing a task instance - #72788

Closed
Kunal8954 wants to merge 3 commits into
apache:mainfrom
Kunal8954:fix-task-state-store-map-index-mispair
Closed

Kunal8954 wants to merge 3 commits into
apache:mainfrom
Kunal8954:fix-task-state-store-map-index-mispair

Conversation

@Kunal8954

Copy link
Copy Markdown
Contributor

Clearing a task instance now deletes its task_state_store rows, so a re-expanded
dynamically mapped task never inherits the state of the item that previously occupied
the same positional map_index.

The state store is keyed by positional map_index and previously survived an
operator-initiated clear. If the expanded upstream list changes between runs (an
insertion, deletion, or reordering), index N on the second attempt is a different
item than index N on the first, and would silently inherit the earlier item's state
(including a stored external-job reference), while the run still reports success.

Airflow's own clear path already regenerates the TaskInstance uuid and deletes XComs
in clear_task_instances; this change adds the state store wipe in the same place.
Automatic retries are not clears and still share rows, so durable execution continues
to resume a failed attempt from its last checkpoint. The docs (resumable-tasks.rst
and task-state-store.rst) are updated to describe clearing as a controlled reset and
to document the positional-index caveat for mapped tasks.

closes: #72725


Was generative AI tooling used to co-author this PR?
  • Yes — big-pickle (opencode/big-pickle)

Generated-by: big-pickle (opencode/big-pickle) following the guidelines

An operator-initiated clear now deletes the task's state store rows, so a
re-expanded dynamically mapped task never inherits the state of the item
that previously occupied the same positional map_index. Automatic retries
still share rows, so durable execution continues to resume a failed attempt
from its last checkpoint.
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Kunal8954 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 8 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed because of open PR limit Closed as a one-time step of introducing the open pull request limit kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task state store is keyed by positional map_index and survives a clear, so a re-expanded list silently inherits the wrong item's state

2 participants