Skip to content

Reconnect Data Fusion pipelines after task retries - #72415

Closed
1fanwang wants to merge 3 commits into
apache:mainfrom
1fanwang:datafusion-resumable-runs
Closed

1fanwang wants to merge 3 commits into
apache:mainfrom
1fanwang:datafusion-resumable-runs

Conversation

@1fanwang

@1fanwang 1fanwang commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Why

If a worker exits after starting a synchronous Data Fusion pipeline, the retry starts another run while the first one keeps running.

The retry now reconnects with the stored runId. Completed runs return without another submission. Failed, killed, or rejected runs start fresh.

What

The synchronous polling path uses AIP-103's ResumableJobMixin. It stores the exact runId before polling and restores that run with get_pipeline_workflow. Lookup errors stop the task rather than risk a duplicate.

Asynchronous and deferrable execution keep their existing submission behavior. Airflow versions before 3.3 also keep the non-durable path.

Tests

Task-state red/green proof
$ AIRFLOW_HOME=/tmp/airflow-datafusion-e2e-base .venv/bin/uv run --project providers/google python dev/datafusion_resumability_e2e.py --git-ref upstream/main --expect-recovery
retry_result=run-002 completed_result=run-003 submissions=3 polls=3
store_events=
recovery=FAIL

$ AIRFLOW_HOME=/tmp/airflow-datafusion-e2e-current .venv/bin/uv run --project providers/google python dev/datafusion_resumability_e2e.py --expect-recovery
retry_result=run-001 completed_result=run-001 submissions=1 polls=2
store_events=GET datafusion_pipeline_run_id=None | SET datafusion_pipeline_run_id=run-001 | GET datafusion_pipeline_run_id=run-001 | GET datafusion_pipeline_run_id=run-001
recovery=PASS

red_status=1 green_status=0

Risk

Only synchronous polling uses recovery. Unknown nonterminal states reconnect, and exact-run lookup failures propagate.


Was generative AI tooling used to co-author this PR?
  • Yes, GitHub Copilot CLI (GPT-5.6 Sol)

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

Synchronous pipeline tasks can outlive a worker process. A task retry currently submits a second Data Fusion run instead of reconnecting to the exact run already in progress.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Sep 2, 2026
Task-state recovery is unavailable on older Airflow releases, so those compatibility jobs must exercise only the fresh-submit fallback.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
The compatibility suite exercises legacy link persistence, which requires the operator in the task context.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @1fanwang - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 34 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers closed because of open PR limit Closed as a one-time step of introducing the open pull request limit provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants