Skip to content

Prevent duplicate Anthropic batches on task retry - #72400

Closed
1fanwang wants to merge 3 commits into
apache:mainfrom
1fanwang:anthropic-batch-resumability
Closed

1fanwang wants to merge 3 commits into
apache:mainfrom
1fanwang:anthropic-batch-resumability

Conversation

@1fanwang

@1fanwang 1fanwang commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Synchronous AnthropicBatchOperator retries can submit a second billable Message Batch after a worker exits while polling. The batch ID is available through XCom, but Airflow clears XCom before the retry, so the next attempt cannot reconnect.

On Airflow 3.3+, synchronous waits now persist the batch ID through ResumableJobMixin. A retry reconnects to an in_progress batch or returns a completed successful batch without another submission. It submits fresh work when the stored batch is missing, failed, expired, canceling, or contains canceled requests. Deferrable execution and wait_for_completion=False retain their current behavior.

Testing

The regression drives two attempts through the real operator with a local task-state backing and mocked Anthropic API. On upstream/main, the retry submits twice. This branch reconnects to the first batch.

Source Result
upstream/main with this PR's regression test Failed: create_batch called twice
This PR Passed: one submission across both attempts
Raw retry regression
$ breeze run pytest providers/anthropic/tests/unit/anthropic/operators/test_batch.py::TestAnthropicBatchOperatorExecute::test_retry_reconnects_to_first_submission -q
providers/anthropic/tests/unit/anthropic/operators/test_batch.py::TestAnthropicBatchOperatorExecute::test_retry_reconnects_to_first_submission FAILED
E   AssertionError: Expected 'create_batch' to be called once. Called 2 times.
E   Calls: [call([{'custom_id': 'a', 'params': {'model': 'claude-opus-4-8', 'max_tokens': 8, 'messages': []}}], model=None),
E    call([{'custom_id': 'a', 'params': {'model': 'claude-opus-4-8', 'max_tokens': 8, 'messages': []}}], model=None)].
======================== 1 failed, 1 warning in 18.19s =========================

$ breeze run pytest providers/anthropic/tests/unit/anthropic/operators/test_batch.py::TestAnthropicBatchOperatorExecute::test_retry_reconnects_to_first_submission -q
providers/anthropic/tests/unit/anthropic/operators/test_batch.py::TestAnthropicBatchOperatorExecute::test_retry_reconnects_to_first_submission PASSED
======================== 1 passed, 1 warning in 17.93s =========================
Provider suites
$ breeze run pytest providers/anthropic/tests/unit/anthropic/operators/test_batch.py -xs
37 passed, 1 warning in 16.70s

$ breeze run pytest providers/anthropic/tests -xs
222 passed, 1 warning in 18.63s

$ breeze testing providers-tests --test-type "Providers[anthropic,common.compat]"
419 passed, 3 skipped, 1 warning in 24.41s

Was generative AI tooling used to co-author this PR?
  • Yes - GitHub Copilot CLI (GPT-5.6 Sol)

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) following the guidelines

Synchronous retries can submit another billable Message Batch after worker loss. Reconnecting to the saved batch keeps retries on the original remote work while preserving existing deferrable and no-wait behavior.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
The Airflow 3.2 compatibility path calls methods supplied by the concrete operator, which left the resumability change valid at runtime but rejected by MyPy.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
A canceled batch cannot produce a complete result, so reconnecting on retry can skip the task or return only a subset of requests.

Generated-by: GitHub Copilot CLI (GPT-5.6 Sol)
Signed-off-by: 1fanwang <[email protected]>
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @1fanwang - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 34 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers closed because of open PR limit Closed as a one-time step of introducing the open pull request limit kind:documentation provider:anthropic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants