Repository navigation
Fix comma-separated selected_fields in BigQuery to SQL transfers - #71775
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <[email protected]>
boring-cyborg
Bot
added
area:providers
provider:google
| ) -> None: | ||
| super().__init__(**kwargs) | ||
| if isinstance(selected_fields, str): | ||
| selected_fields = [field.strip() for field in selected_fields.split(",") if field.strip()] |
There was a problem hiding this comment.
Was treating an empty normalized string as “all fields” intentional? Would it be safer to raise ValueError when a provided string contains no valid fields and add a test for that case? Did you test this case as well?
potiuk
added
the
closed because of open PR limit
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
The docstring says selected_fields is a "List of fields to return (comma-separated)". The operator passes that value to two places: BigQueryHook.list_rows() splits it on commas, but insert_rows(target_fields=...) does not.
common.sqlbuilds the column list with", ".join(map(escape_word, target_fields)), so a string is iterated character by character. Withselected_fields="emp_name,salary":How
BigQueryToSqlBaseOperator.__init__normalises a comma-separated string intolist[str], soBigQueryToPostgres/BigQueryToMySql/BigQueryToMsSqlall get a real column list on both the BigQuery read and the SQL write side.Verification
uv run --project providers/google pytest providers/google/tests/unit/google/cloud/transfers/test_bigquery_to_postgres.py providers/google/tests/unit/google/cloud/transfers/test_bigquery_to_mysql.py -vWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.