Repository navigation
Conversation
The MySQL branch of this downgrade passed two statements to a single op.execute(). PyMySQL does not enable CLIENT.MULTI_STATEMENTS, so it rejects the script with a syntax error and the downgrade cannot run. mysqlclient enables multi-statements, which is why the problem is invisible to anyone using that driver. Signed-off-by: 1fanwang <[email protected]>
8490e3d to
ee3ec1c
Compare
potiuk
added
the
closed because of open PR limit
|
Hello @1fanwang - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 34 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
The MySQL branch of this downgrade passes two statements to a single
op.execute():PyMySQL does not enable
CLIENT.MULTI_STATEMENTS, so it rejects the script with a syntax error and the downgrade cannot run. mysqlclient does enable it, which is why the problem is invisible to anyone on that driver, including CI:scripts/ci/docker-compose/backend-mysql.ymluses a baremysql://URL, which SQLAlchemy resolves tomysqldb.Splitting into two
op.execute()calls fixes it.op.execute()reusesop.get_bind(), so@row_numberis still visible to theUPDATE.Same class of bug as PR #70235, which fixes the multi-statement SQL in
0017_2_9_2. I found this one while looking at that PR. The two do not overlap.Testing Done
MySQL 8.4, the migration's own SQL against both drivers, before and after.
Raw logs
Table seeded with
try_idout of order (30, 10, 20) so the renumbering is observable:The fix produces identical numbering on both drivers, confirming the session variable survives across the two calls and the
ORDER BY try_idsequencing is unchanged.