Skip to content

[v3-3-test] Decide pod_template and image based on Coordinator for lang-SDK tasks on KubernetesExecutor (#68713)#69536

Merged
jason810496 merged 1 commit into
apache:v3-3-testfrom
astronomer:backport-512a044-to-v3-3-test
Jul 7, 2026
Merged

[v3-3-test] Decide pod_template and image based on Coordinator for lang-SDK tasks on KubernetesExecutor (#68713)#69536
jason810496 merged 1 commit into
apache:v3-3-testfrom
astronomer:backport-512a044-to-v3-3-test

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 7, 2026

Copy link
Copy Markdown
Member
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jul 7, 2026
@Lee-W Lee-W requested a review from jason810496 July 7, 2026 10:38
@Lee-W

Lee-W commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

This seems to be something that blocks #69532

@Lee-W Lee-W requested review from guan404ming and henry3260 July 7, 2026 10:39
jason810496
jason810496 approved these changes Jul 7, 2026
View reviewed changes

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes this is one of the version-aware example I mentioned.

I will make this reference upstream/main as follow up.

jason810496
jason810496 reviewed Jul 7, 2026
View reviewed changes

@jason810496 jason810496 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI for the further reviewers that this PR (#69536) needs to merge before #69532.

@jason810496 jason810496 mentioned this pull request Jul 7, 2026
Merged
1 task
@jason810496

jason810496 commented Jul 7, 2026

Copy link
Copy Markdown
Member

The only fail CI (chicken-egg problem, we have to merge this PR to solve this CI failure) to I will merge this right away.

  Check Go toolchain version is consistent across build files..................................................Failed
  - hook id: check-go-version-in-sync
  - exit code: 1

    ERROR: Go version pin not found in kubernetes-tests/lang_sdk/go_example/go.mod
    ERROR: Go version pin not found in dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py
           (expected pattern '^go\\s+(\\d+\\.\\d+(?:\\.\\d+)?)\\s*$')
           (expected pattern 'golang:(\\d+\\.\\d+(?:\\.\\d+)?)-alpine')

@jason810496 jason810496 merged commit df53718 into apache:v3-3-test Jul 7, 2026
89 of 90 checks passed
@jason810496 jason810496 deleted the backport-512a044-to-v3-3-test branch July 7, 2026 12:06
@github-actions github-actions Bot added this to the Airflow 3.3.1 milestone Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.1 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason810496 jason810496 jason810496 approved these changes
@potiuk potiuk potiuk approved these changes
@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner
@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner
@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner
@henry3260 henry3260 Awaiting requested review from henry3260
@guan404ming guan404ming Awaiting requested review from guan404ming

Assignees

No one assigned

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Lee-W @jason810496 @potiuk