Skip to content

Enforce pool team ownership in scheduling loop#68649

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/fix_pool_cross_team_enforcement
Jun 17, 2026
Merged

Enforce pool team ownership in scheduling loop#68649
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/fix_pool_cross_team_enforcement

Conversation

@o-nikolas

Copy link
Copy Markdown
Contributor

The scheduler's _executable_task_instances_to_queued bypassed pool team ownership checks, allowing tasks from one team to use pools owned by another team. The existing PoolSlotsAvailableDep had the correct logic but was never invoked in the scheduler's critical section.

Add an inline team check that batch-resolves pool-to-team mappings and blocks cross-team pool access before tasks are queued for execution.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The scheduler's _executable_task_instances_to_queued bypassed pool team
ownership checks, allowing tasks from one team to use pools owned by
another team. The existing PoolSlotsAvailableDep had the correct logic
but was never invoked in the scheduler's critical section.

Add an inline team check that batch-resolves pool-to-team mappings and
blocks cross-team pool access before tasks are queued for execution.
@o-nikolas o-nikolas requested review from XD-DENG and ashb as code owners June 17, 2026 00:39
@boring-cyborg boring-cyborg Bot added the area:Scheduler including HA (high availability) scheduler label Jun 17, 2026
@o-nikolas o-nikolas requested a review from vincbeck June 17, 2026 00:39
@o-nikolas o-nikolas added this to the Airflow 3.3.0 milestone Jun 17, 2026
@vincbeck vincbeck merged commit 6b41214 into apache:main Jun 17, 2026
77 checks passed
@vincbeck vincbeck deleted the onikolas/fix_pool_cross_team_enforcement branch June 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Scheduler including HA (high availability) scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants