Forward run-identity attributes to the trace sampler#68592
Merged
Conversation
dstandish
requested review from
XD-DENG,
amoghrajesh,
ashb,
kaxil and
potiuk
as code owners
dstandish
force-pushed
the
acd-177-sampler-attributes
branch
2 times, most recently
from
e0ca376 to
a1652b3
Compare
ashb
approved these changes
Jun 18, 2026
dstandish
force-pushed
the
acd-177-sampler-attributes
branch
from
a1652b3 to
9e6f19d
Compare
ashb
approved these changes
Jun 18, 2026
dstandish
force-pushed
the
acd-177-sampler-attributes
branch
2 times, most recently
from
2d6dc50 to
8ca4a15
Compare
1 task
Builds on the head-sampling foundation (apache#68591) by forwarding run-identity attributes (dag_id, run_type) to the trace sampler, so a custom sampler can differentiate the head-sampling decision by run kind.
dstandish
force-pushed
the
acd-177-sampler-attributes
branch
from
8ca4a15 to
3b81bab
Compare
cetingokhan
pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
Builds on the head-sampling foundation (apache#68591) by forwarding run-identity attributes (dag_id, run_type, run_id) to the trace sampler, so a custom sampler can differentiate the head-sampling decision by run kind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #68591. Until that merges, this PR's diff also includes its commits — review only the final commit, "Forward run-identity attributes to the trace sampler". Will rebase once #68591 lands.What
Builds on the head-sampling change in #68591. Adds a generic
attributesparam tonew_dagrun_trace_carrier, forwarded tosampler.should_sample(...), so a custom sampler can differentiate the head-sampling decision by run kind (e.g. byairflow.dag_id/airflow.run_type).A shared
dagrun_trace_attributes(dr)helper defines those identity attributes once and is reused at both carrier-creation sites (DagRun.__init__and the clear path) and on the emitteddag_runspan — which now also carriesairflow.run_type(previously onlydag_id).Notes
_emit_dagrun_spanpasses its attributes intostart_span, which the SDK forwards toshould_sampleagain (the dag_run span re-samples as a root), so a custom sampler sees them there too.🤖 Generated with Claude Code