Skip to content

UI: Add custom expiration datetime picker for task store modal#68394

Merged
amoghrajesh merged 3 commits into
apache:mainfrom
astronomer:aip-103-task-store-modal
Jun 12, 2026
Merged

UI: Add custom expiration datetime picker for task store modal#68394
amoghrajesh merged 3 commits into
apache:mainfrom
astronomer:aip-103-task-store-modal

Conversation

@amoghrajesh

@amoghrajesh amoghrajesh commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes claude sonnet

What

The "Custom" expiration option in the Add/Edit Task Store modal was stubbed out and disabled, with a TODO comment waiting for a datetime picker component. DateTimeInput already existed but wasn't wired up.

image (89)

Current behaviour

The "Custom" radio card in the Expiration section is disabled. Users can only choose "Default (30 days)" or "Never" — there is no way to set an arbitrary expiration datetime via the UI.

Proposed change

Enables the "Custom" option and renders a DateTimeInput below the radio group when it is selected. The picker respects the user's selected Airflow timezone and enforces a min of the current time so past datetimes cannot be chosen. The selected datetime is sent to the core API as an ISO 8601 string. Edit mode hydrates the picker correctly when an existing entry has a specific expires_at.

The Save button remains disabled until a date is entered when "Custom" is selected.

Testing

Adding a new task store

image

After its added

image
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Comment thread airflow-core/src/airflow/ui/src/pages/TaskStore/TaskStoreModal.tsx
@amoghrajesh amoghrajesh requested a review from bbovenzi June 11, 2026 16:37
@amoghrajesh amoghrajesh merged commit a57fcc1 into apache:main Jun 12, 2026
84 of 85 checks passed
@amoghrajesh amoghrajesh deleted the aip-103-task-store-modal branch June 12, 2026 04:08
@github-project-automation github-project-automation Bot moved this from In progress to Done in AIP-103: Task State Management Jun 12, 2026
imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Jun 16, 2026
dingo4dev pushed a commit to dingo4dev/airflow that referenced this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants