Skip to content

feat: Add fullscreen toggle to code viewer#68044

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:feat/fullscreen-toggle-code-view
Jun 12, 2026
Merged

feat: Add fullscreen toggle to code viewer#68044
choo121600 merged 1 commit into
apache:mainfrom
choo121600:feat/fullscreen-toggle-code-view

Conversation

@choo121600

@choo121600 choo121600 commented Jun 4, 2026

Copy link
Copy Markdown
Member

Why

The Dag code view became a small, fixed-height window in Airflow 3.2, showing only a few lines.
This restores it to fill the available height and adds a fullscreen toggle (button, hotkey f, Esc to exit) for reading longer files.

Screen.Recording.2026-06-11.at.11.23.47.PM.mov

related: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    claude opus 4.7

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Jun 4, 2026
@eladkal eladkal added this to the Airflow 3.3.0 milestone Jun 7, 2026
@eladkal eladkal added the type:improvement Changelog: Improvements label Jun 7, 2026

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already do a lot of this to see logs in full screen. Let's reuse approaches, including translation keys.

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Brent mentioned it would be more consistent to mirror what we do for logs.

Refactor a bit to reuse dag:logs.fullscreen.tooltip translation keys and similar and use a fullscreen Dialog component.

Image

@choo121600 choo121600 force-pushed the feat/fullscreen-toggle-code-view branch from 735ce31 to d975bf3 Compare June 11, 2026 13:41
@choo121600 choo121600 marked this pull request as draft June 11, 2026 13:53
@choo121600 choo121600 force-pushed the feat/fullscreen-toggle-code-view branch from d975bf3 to 1dd8a55 Compare June 11, 2026 13:53
@choo121600

choo121600 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Thanks, I've updated it to mirror the logs view implementation :)

Screen.Recording.2026-06-11.at.11.23.47.PM.mov

While doing that, I noticed a few inconsistencies across views around things like icons, tooltips, and button patterns.
I'll see if I can clean those up in a follow-up PR.

@choo121600 choo121600 marked this pull request as ready for review June 11, 2026 16:03
@choo121600 choo121600 added the backport-to-v3-3-test Backport to v3-3-test label Jun 12, 2026
@choo121600 choo121600 merged commit 460cf26 into apache:main Jun 12, 2026
164 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Jun 16, 2026
dingo4dev pushed a commit to dingo4dev/airflow that referenced this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test translation:default type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants