Repository navigation
[v3-2-test] Fix scheduler orphaned task reset logging crash (#67822) - #67844
Merged
Merged
Conversation
The scheduler orphaned-task adoption path loaded task instances with a narrow load_only(...) set and then called repr(ti) while building the reset log message. TaskInstance.__repr__ reads map_index and state, so detached instances with deferred columns could raise DetachedInstanceError and crash the scheduler on restart.
ashb
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #67822 to
v3-2-test.The scheduler orphaned-task adoption path loaded task instances with a narrow
load_only(...)set and then calledrepr(ti)while building the reset log message.TaskInstance.__repr__readsmap_indexandstate, so detached instances with deferred columns could raiseDetachedInstanceErrorand crash the scheduler on restart.This backport applies the original change as-is. The only cherry-pick conflict was an adjacent, unrelated test on
main(test_clear_task_instances_preserves_detail_level, from a separate un-backported PR whoseget_task_span_detail_levelfeature does not exist onv3-2-test); it was excluded, so the delta here is exactly #67822.related: #67813
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines