fix(ui): avoid false unused plural keys in translation completeness checker#65259
Merged
Merged
Conversation
windro-xdd
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
2 tasks
potiuk
approved these changes
Apr 14, 2026
Member
|
Pending CI passes. |
potiuk
force-pushed
the
fix-65229-plural-forms-checker
branch
from
136a24f to
a655664
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…mpleteness check (#65259) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 14, 2026
…mpleteness check (apache#65259) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
potiuk
pushed a commit
that referenced
this pull request
Apr 14, 2026
…mpleteness check (#65259) (#65270) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…mpleteness check (#65259) (#65270) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…mpleteness check (#65259) (#65270) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…mpleteness check (#65259) (#65270) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…mpleteness check (#65259) (#65270) (cherry picked from commit e7a3124) Co-authored-by: Windro.xd <[email protected]> Co-authored-by: test <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-translation-completenessso plural keys are expanded not only when EN contains{{count}}, but also when EN already has multiple plural forms for the same base (for example_one+_other).Why
Issue #65229 reports that language-specific plural forms can be marked as unused even when plural routing is active.
Tests
uv run ruff format dev/breeze/src/airflow_breeze/commands/ui_commands.py dev/breeze/tests/test_ui_commands.pyuv run ruff check --fix dev/breeze/src/airflow_breeze/commands/ui_commands.py dev/breeze/tests/test_ui_commands.pyuv run --project dev/breeze pytest dev/breeze/tests/test_ui_commands.py -xvsCloses #65229