Skip to content

fix(ui): register trigger and sensor graph node types#65167

Merged
bbovenzi merged 7 commits into
apache:mainfrom
windro-xdd:fix-trigger-node-clean-v2
Apr 15, 2026
Merged

fix(ui): register trigger and sensor graph node types#65167
bbovenzi merged 7 commits into
apache:mainfrom
windro-xdd:fix-trigger-node-clean-v2

Conversation

@windro-xdd

@windro-xdd windro-xdd commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Register missing trigger and sensor node type mappings in UI graph nodeTypes to avoid render failures when those node kinds appear in dependency graphs
  • Add focused unit test coverage for the new node type registrations
  • Keep scope intentionally minimal (no i18n or unrelated file changes)

Testing

  • pnpm test src/components/Graph/graphTypes.test.ts
  • pnpm test src/components/Graph
  • pnpm lint
  • pnpm build

Screenshot

Screenshot added - DAG graph view showing proper rendering of trigger and sensor nodes with the fix applied. See comments below for details.

Supersedes #64689.

Closes #64621
Closes #49576

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 13, 2026
Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.
@windro-xdd windro-xdd force-pushed the fix-trigger-node-clean-v2 branch from 9d8f6f5 to 8fe517c Compare April 13, 2026 18:31
@windro-xdd

Copy link
Copy Markdown
Contributor Author

Screenshot (trigger + sensor nodes rendering)

Added screenshot to this PR branch:

airflow-core/src/airflow/ui/src/components/Graph/trigger-sensor-graph-screenshot.png

Preview:

Trigger and sensor nodes graph screenshot

What this shows:

  • wait_sensor rendered as TimeDeltaSensor
  • trigger_next rendered as TriggerDagRunOperator
  • Graph view renders both node kinds without blanking/crashing

Comment thread airflow-core/src/airflow/ui/src/components/Graph/graphTypes.ts
@windro-xdd

Copy link
Copy Markdown
Contributor Author

Thanks for the review and for calling out the scope.

I cleaned this PR so it only includes graphTypes.ts now.

  • Removed graphTypes.test.ts
  • Removed the committed screenshot file

The screenshot context came from the earlier closed PR discussion (#64689), where a screenshot had been requested. I kept that context in comments only, but removed non-essential files from this PR so the diff stays focused on the single file fix.

@bbovenzi

Copy link
Copy Markdown
Contributor

Great. Thanks for working on this and for graciously responding to the reviews in your previous PR.

@windro-xdd

Copy link
Copy Markdown
Contributor Author

Thanks again for the review and guidance. I’m still getting used to the project workflow, and I really appreciate the patience and feedback.

@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Apr 14, 2026
@bbovenzi bbovenzi merged commit e0ed795 into apache:main Apr 15, 2026
81 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 15, 2026
…5167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

vatsrahul1001 pushed a commit that referenced this pull request Apr 16, 2026
…5167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
pierrejeambrun pushed a commit that referenced this pull request Apr 16, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Apr 16, 2026
* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------

Co-authored-by: Kripa Dev <[email protected]>
vatsrahul1001 pushed a commit that referenced this pull request Apr 17, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
vatsrahul1001 pushed a commit that referenced this pull request Apr 20, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…5167) (#65321)

* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)

Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).

Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)



---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-updates
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)

* Add breeze generate issue content for airflow-ctl

* add new command to doc
(cherry picked from commit b24538b)

Co-authored-by: Justin Pakzad <[email protected]>

* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)

* Move release calendar verification to its own scheduled workflow

Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.

* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)

* [v3-2-test] fix(ui): register trigger and sensor graph node types (#65167)

* fix(ui): register trigger and sensor graph node types

Adds missing Graph node type mappings for trigger/sensor and includes a focused unit test to prevent regressions where dependency graph rendering breaks for those node kinds.

* docs(ui): add graph screenshot showing sensor and trigger nodes

* chore(ui): keep PR scoped to graphTypes.ts only

---------
(cherry picked from commit e0ed795)

Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Justin Pakzad <[email protected]>
Co-authored-by: Windro.xd <[email protected]>
Co-authored-by: Kripa Dev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes

Projects

None yet

3 participants