Re export AirflowPlugin to fix mypy errors in plugins#65132
Conversation
|
Interesting - is that enough ? That does not sound like this should have such effect ? Is it A Typing/MyPy specific thing that you have to do 'X as X' to be visible in MyPy as explicitly exposed ? |
|
Ah TIL |
|
import - In Python, what's the purpose of giving an alias with the same name as the imported lib? - Stack Overflow https://share.google/7zvymClHaTqQuUHiA |
|
I personally prefer all but this works too :) |
Yeah :D I do not have a strong preference but I like re importing with same name, makes it a bit explicit / more "re export" like. |
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool, thanks for the quick fix!
|
Can we get this into 3.2.1? |
…ache#65132) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
I believe everything in v3-2-test goes to 3.2.1 now :) |
…5132) (#65163) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
…5132) (#65163) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
…5132) (#65163) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
…5132) (#65163) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
…5132) (#65163) (cherry picked from commit 521d525) Co-authored-by: Amogh Desai <[email protected]>
3 participants
Was generative AI tooling used to co-author this PR?
Custom plugins written with
AirflowPluginface mypy errors:The best way to do this is to re export them from the packages that are public API for it.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.