Skip to content

[v3-2-test] Replace upgrade-check build failure with scheduled upgrad…#64915

Merged
potiuk merged 1 commit into
v3-2-testfrom
backport-dd0ff5a-v3-2-test
Apr 8, 2026
Merged

[v3-2-test] Replace upgrade-check build failure with scheduled upgrad…#64915
potiuk merged 1 commit into
v3-2-testfrom
backport-dd0ff5a-v3-2-test

Conversation

@potiuk

@potiuk potiuk commented Apr 8, 2026

Copy link
Copy Markdown
Member

…e PR workflow (#64836)

Move upgrade checks from basic-tests.yml (where they failed the build) to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for v3-2-test. The workflow uses breeze ci upgrade to run all upgrade steps and create a draft PR. A Slack notification is sent to #internal-airflow-ci-cd when a PR needs review.

Changes:

  • Remove upgrade-check job from basic-tests.yml
  • Add reusable upgrade-check.yml workflow (workflow_call)
  • Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
  • Enhance breeze ci upgrade: --draft flag, stable branch naming, existing PR detection, no -w flag for CI compatibility (cherry picked from commit dd0ff5a)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…e PR workflow (#64836)

Move upgrade checks from basic-tests.yml (where they failed the build)
to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for
v3-2-test. The workflow uses `breeze ci upgrade` to run all upgrade
steps and create a draft PR. A Slack notification is sent to
#internal-airflow-ci-cd when a PR needs review.

Changes:
- Remove upgrade-check job from basic-tests.yml
- Add reusable upgrade-check.yml workflow (workflow_call)
- Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
- Enhance breeze ci upgrade: --draft flag, stable branch naming,
  existing PR detection, no -w flag for CI compatibility
(cherry picked from commit dd0ff5a)

Co-authored-by: Jarek Potiuk <[email protected]>
@potiuk potiuk merged commit 2eeff98 into v3-2-test Apr 8, 2026
2 checks passed
@potiuk potiuk deleted the backport-dd0ff5a-v3-2-test branch April 8, 2026 19:41
@jscheffl

jscheffl commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Cool!

breeze ci upgrade
--target-branch "${TARGET_BRANCH}"
--create-pr
--draft

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why actually do we set it to draft only? Then you need to undraft first and need to wait until build is complete before able to merge.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it won't run when PR is created by workflow (limitation of GH actions). Workflows do not start when another workflow creates PR (prevents recursive workflows) - and PR is green. You need Human action to start workflows - and We already tested it with cherry-picker that the best approach is to create the PR as Draft.

vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…e PR workflow (#64836) (#64915)

Move upgrade checks from basic-tests.yml (where they failed the build)
to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for
v3-2-test. The workflow uses `breeze ci upgrade` to run all upgrade
steps and create a draft PR. A Slack notification is sent to
#internal-airflow-ci-cd when a PR needs review.

Changes:
- Remove upgrade-check job from basic-tests.yml
- Add reusable upgrade-check.yml workflow (workflow_call)
- Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
- Enhance breeze ci upgrade: --draft flag, stable branch naming,
  existing PR detection, no -w flag for CI compatibility
(cherry picked from commit dd0ff5a)
@vatsrahul1001 vatsrahul1001 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 15, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.2.1 milestone Apr 15, 2026
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…e PR workflow (#64836) (#64915)

Move upgrade checks from basic-tests.yml (where they failed the build)
to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for
v3-2-test. The workflow uses `breeze ci upgrade` to run all upgrade
steps and create a draft PR. A Slack notification is sent to
#internal-airflow-ci-cd when a PR needs review.

Changes:
- Remove upgrade-check job from basic-tests.yml
- Add reusable upgrade-check.yml workflow (workflow_call)
- Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
- Enhance breeze ci upgrade: --draft flag, stable branch naming,
  existing PR detection, no -w flag for CI compatibility
(cherry picked from commit dd0ff5a)
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…e PR workflow (#64836) (#64915)

Move upgrade checks from basic-tests.yml (where they failed the build)
to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for
v3-2-test. The workflow uses `breeze ci upgrade` to run all upgrade
steps and create a draft PR. A Slack notification is sent to
#internal-airflow-ci-cd when a PR needs review.

Changes:
- Remove upgrade-check job from basic-tests.yml
- Add reusable upgrade-check.yml workflow (workflow_call)
- Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
- Enhance breeze ci upgrade: --draft flag, stable branch naming,
  existing PR detection, no -w flag for CI compatibility
(cherry picked from commit dd0ff5a)
vatsrahul1001 pushed a commit that referenced this pull request Apr 15, 2026
…e PR workflow (#64836) (#64915)

Move upgrade checks from basic-tests.yml (where they failed the build)
to a scheduled workflow that runs Mon/Wed/Fri for main and Tue/Thu for
v3-2-test. The workflow uses `breeze ci upgrade` to run all upgrade
steps and create a draft PR. A Slack notification is sent to
#internal-airflow-ci-cd when a PR needs review.

Changes:
- Remove upgrade-check job from basic-tests.yml
- Add reusable upgrade-check.yml workflow (workflow_call)
- Add scheduled-upgrade-check.yml caller (cron + workflow_dispatch)
- Enhance breeze ci upgrade: --draft flag, stable branch naming,
  existing PR detection, no -w flag for CI compatibility
(cherry picked from commit dd0ff5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants