chart: api-server Deployment always includes spec.replicas when HPA is enabled#63187
Merged
jscheffl merged 1 commit intoMar 11, 2026
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
thejoeejoee
requested review from
bugraoz93,
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
jscheffl
reviewed
Mar 9, 2026
jscheffl
approved these changes
Mar 9, 2026
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Let's have CI green, then LGTM in my view.
Miretpl
requested changes
Mar 10, 2026
thejoeejoee
force-pushed
the
fix/chart-api-server-hpa-replicas
branch
from
0b97c47 to
665c6be
Compare
thejoeejoee
requested review from
amoghrajesh,
ashb,
bbovenzi,
bolkedebruin,
choo121600,
dabla,
dheerajturaga,
ephraimbuddy,
gopidesupavan,
jason810496,
josh-fell,
kaxil,
mobuchowski,
pierrejeambrun,
potiuk,
shahar1 and
vincbeck
as code owners
thejoeejoee
requested review from
Fokko,
Lee-W,
XD-DENG,
guan404ming,
o-nikolas,
rawwar,
ryanahamilton,
shubhamraj-git,
uranusjr and
vatsrahul1001
as code owners
thejoeejoee
force-pushed
the
fix/chart-api-server-hpa-replicas
branch
7 times, most recently
from
f636a15 to
61e4c80
Compare
potiuk
added
the
ready for maintainer review
Miretpl
requested changes
Mar 11, 2026
Miretpl
left a comment
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
Generally - looks good.
I checked how it is handled in e.g. workers, and basically it is handled automatically if on e.g. hpa.enabled flag to add/remove replicas field. The same goes for webserver and triggerer, which have HPA/KEDA implemented.
Could we make the behaviour consistent? (below example from webserver):
{{- if not .Values.webserver.hpa.enabled }}
replicas: {{ .Values.webserver.replicas }}
{{- end}}
thejoeejoee
force-pushed
the
fix/chart-api-server-hpa-replicas
branch
2 times, most recently
from
75fcca8 to
0dad3b4
Compare
thejoeejoee
force-pushed
the
fix/chart-api-server-hpa-replicas
branch
from
0dad3b4 to
d1e9c56
Compare
jscheffl
approved these changes
Mar 11, 2026
Miretpl
approved these changes
Mar 11, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
PascalEgn
pushed a commit
to PascalEgn/airflow
that referenced
this pull request
Mar 12, 2026
Pyasma
pushed a commit
to Pyasma/airflow
that referenced
this pull request
Mar 13, 2026
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
apiServer.hpa.enabled: true, the Deployment manifest still containsspec.replicas: 1.HPA modifies this field at runtime, causing GitOps tooling to continuously detect a diff between
the desired state in Git and the live cluster state — a permanent out-of-sync condition.
Fix: wrap
spec.replicaswith akindIs "invalid"guard so the field is omitted entirely whenapiServer.replicasis set to~(null), letting HPA be the sole owner of the replica count.closes: #63186
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Sonnet 4.5 (Sisyphus / OhMyOpenCode) following the guidelines