Conversation
See apache#61205. Airflow is a large, popular project and a reference for other projects. I'd like to remove the historic use of `UV_HTTP_TIMEOUT`, that isn't required today anymore with the changes in uv. This will also benefit airflow, as broken network connections will fail much faster (either triggering a retry quicker, or reporting to the user in less than 4 x 300s = 20min) I've kept the CLI option in the dev script to not break existing invocations, I can also remove it if you think it's safe
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Checking the linked discussion and knowing that default is 30s... and we see recently very many CI errors due to overloaded mirrors and sites - is it really a good idea to reduce timeout from 300s to 30s? I'd fear a degraded CI stability. (Or do we cance UV workspace/files on the runner making the uv runs independent of remote sites?) |
|
The 30s are a read timeout now, meaning it will effectively only fire if no data was transmitted for that period. The current, higher timeout would only be helpful if you expect to have connections that are completely inactive for 30s, then recover to finish the download. (I tried simulating this locally by unplugging the network, but the only effect was that the connection was broken on the OS level and I had the timeout only caused the request to fail faster.) Also note that this timeout was introduced before it was a read timeout, when there was still a total request timeout, where you need the >30s. Now, there is no total request timeout in uv anymore. We don't see any other major project that has adopted uv after that switch was made setting |
jscheffl
left a comment
There was a problem hiding this comment.
Okay, if we see instability later we can still revert this...
|
You need to regenerate breeze docs with prek and remove - inconsistent now- definitions of commands for rich-click. The output of prek hook is quite clear. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v3-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 66b54f8 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
* Remove `UV_HTTP_TIMEOUT` See apache#61205. Airflow is a large, popular project and a reference for other projects. I'd like to remove the historic use of `UV_HTTP_TIMEOUT`, that isn't required today anymore with the changes in uv. This will also benefit airflow, as broken network connections will fail much faster (either triggering a retry quicker, or reporting to the user in less than 4 x 300s = 20min) I've kept the CLI option in the dev script to not break existing invocations, I can also remove it if you think it's safe * Remove `--uv-http-timeout` from launchers too
See #61205.
Airflow is a large, popular project and a reference for other projects. I'd like to remove the historic use of
UV_HTTP_TIMEOUT, that isn't required today anymore with the changes in uv. This will also benefit airflow, as broken network connections will fail much faster (either triggering a retry quicker, or reporting to the user in less than 4 x 300s = 20min)I've kept the CLI option in the dev script to not break existing invocations, I can also remove it if you think it's safe
Was generative AI tooling used to co-author this PR?
The actual diff is mine, claude code helped with reviewing and dev checks.