Skip to content

Added E2E tests for Variables Page#61571

Merged
vatsrahul1001 merged 1 commit intoapache:mainfrom
sarth-akvaish:test/Variable-Page
Feb 16, 2026
Merged

Added E2E tests for Variables Page#61571
vatsrahul1001 merged 1 commit intoapache:mainfrom
sarth-akvaish:test/Variable-Page

Conversation

@sarth-akvaish
Copy link
Contributor

@sarth-akvaish sarth-akvaish commented Feb 7, 2026

This PR adds E2E tests for Admin Variables Page.

Fixes : #60565

Tests Includes -

Test Data - test variables are created using unique key and dummy description and value

  1. Variable Table displays with the data
  2. Editing a variable description
  3. Deleting a variable
  4. Verifying sorting using column header
  5. Filter a variable using search bar
  6. verifying Import variables displays in the list
  7. verify pagination working
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Feb 7, 2026
@sarth-akvaish sarth-akvaish force-pushed the test/Variable-Page branch 6 times, most recently from abc84fd to 4e3e31f Compare February 10, 2026 17:31
@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Feb 11, 2026

@sarth-akvaish looks like few tests are flaky. Can you take a look?

@sarth-akvaish sarth-akvaish force-pushed the test/Variable-Page branch 2 times, most recently from 99fb96c to 08808ea Compare February 12, 2026 10:14
@sarth-akvaish
Copy link
Contributor Author

sarth-akvaish commented Feb 12, 2026

@sarth-akvaish looks like few tests are flaky. Can you take a look?

Hi @vatsrahul1001 , fixed the flaky tests.

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Feb 16, 2026

@sarth-akvaish as discussed here. We plan not to include pagination and sorting tests in E2E lets remove them. Also ensure we have tests related to below

  • Verify variables list displays
  • Create variable
  • Edit variable
  • Delete variable
  • Search variables
  • Import variables from file

@sarth-akvaish
Copy link
Contributor Author

sarth-akvaish commented Feb 16, 2026

@sarth-akvaish as discussed here. We plan not to include pagination and sorting tests in E2E lets remove them. Also ensure we have tests related to below

  • Verify variables list displays
  • Create variable
  • Edit variable
  • Delete variable
  • Search variables
  • Import variables from file

Sure, will update the PR

@vatsrahul1001 vatsrahul1001 merged commit 5c9cf6a into apache:main Feb 16, 2026
78 checks passed
@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Feb 16, 2026

Nice!

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Feb 18, 2026

@sarth-akvaish I see some failure due to these test in Daily C run. Can you take a look?

@sarth-akvaish
Copy link
Contributor Author

sarth-akvaish commented Feb 18, 2026

@sarth-akvaish I see some failure due to these test in Daily C run. Can you take a look?

Hi, can I create a new PR fixing this webkit test issue, and also removing the pagination test for provider page..?

@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Feb 18, 2026

@sarth-akvaish I see some failure due to these test in Daily C run. Can you take a look?

Hi, can I create a new PR fixing this webkit test issue, and also removing the pagination test for provider page..?

Yes please

choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@sarth-akvaish @choo121600
Added E2E tests for Variables (apache#61571)
4aacec5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@choo121600 choo121600 choo121600 left review comments

@vatsrahul1001 vatsrahul1001 vatsrahul1001 approved these changes

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI E2E Test || ADMIN-001: Verify Variables Page functionality

3 participants

@sarth-akvaish @vatsrahul1001 @choo121600