Skip to content

Fix GZipMiddleware with correct comment placement#61538

Merged
jason810496 merged 1 commit into
apache:mainfrom
Eason09053360:fix-gzip-middleware
Feb 7, 2026
Merged

Fix GZipMiddleware with correct comment placement#61538
jason810496 merged 1 commit into
apache:mainfrom
Eason09053360:fix-gzip-middleware

Conversation

@Eason09053360

@Eason09053360 Eason09053360 commented Feb 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add GZipMiddleware with correct comment placement, as suggested in issue #61043.

Changes

  • Ensured comments are correctly placed above the middleware definition to comply with review feedback.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Feb 6, 2026
pierrejeambrun
pierrejeambrun approved these changes Feb 6, 2026
View reviewed changes

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.8 milestone Feb 6, 2026
@pierrejeambrun pierrejeambrun mentioned this pull request Feb 6, 2026
Merged
@jason810496 jason810496 changed the title Add GZipMiddleware with correct comment placement Fix GZipMiddleware with correct comment placement Feb 7, 2026
@jason810496 jason810496 merged commit 54d7852 into apache:main Feb 7, 2026
129 checks passed
@boring-cyborg

boring-cyborg Bot commented Feb 7, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 54d7852 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

jason810496 pushed a commit to jason810496/airflow that referenced this pull request Feb 7, 2026
@Eason09053360 @jason810496
[v3-1-test] Fix GZipMiddleware with correct comment placement (apache…
bb93610 
…#61538)

(cherry picked from commit 54d7852)
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@Eason09053360 @jhgoebbert
Fix GZipMiddleware with correct comment placement (apache#61538)
6e2ba91
@github-actions

github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 54d7852 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

jason810496 added a commit that referenced this pull request Feb 9, 2026
@jason810496 @Eason09053360
[v3-1-test] Fix GZipMiddleware with correct comment placement (#61538) (
10f2751 
#61566)

(cherry picked from commit 54d7852)

Co-authored-by: Eason09053360 <[email protected]>
@pierrejeambrun

pierrejeambrun commented Feb 10, 2026

Copy link
Copy Markdown
Member

backport is done, thanks

Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
@Eason09053360 @Ratasa143
Fix GZipMiddleware with correct comment placement (apache#61538)
4fc924c
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@Eason09053360 @choo121600
Fix GZipMiddleware with correct comment placement (apache#61538)
f86c5f3
AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 27, 2026
@Eason09053360
Fix GZipMiddleware with correct comment placement (apache#61538)
081f90c
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@Eason09053360 @Subham-KRLX
Fix GZipMiddleware with correct comment placement (apache#61538)
1ef06ec
vatsrahul1001 pushed a commit that referenced this pull request Mar 4, 2026
@jason810496 @Eason09053360 @vatsrahul1001
[v3-1-test] Fix GZipMiddleware with correct comment placement (#61538) (
b38c3a0 
#61566)

(cherry picked from commit 54d7852)

Co-authored-by: Eason09053360 <[email protected]>
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
@Eason09053360 @dominikhei
Fix GZipMiddleware with correct comment placement (apache#61538)
921877d
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@Eason09053360 @Ankurdeewan
Fix GZipMiddleware with correct comment placement (apache#61538)
eeecde4
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
@Eason09053360
Fix GZipMiddleware with correct comment placement (apache#61538)
6ea8d9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes
@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner
@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner
@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner
@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Milestone

Airflow 3.1.8

Development

Successfully merging this pull request may close these issues.

3 participants

@Eason09053360 @pierrejeambrun @jason810496