Skip to content

Amend Breeze and release difference on naming#61291

Closed
bugraoz93 wants to merge 1 commit intoapache:mainfrom
bugraoz93:update-reproducible-checks-on-release-docs
Closed

Amend Breeze and release difference on naming#61291
bugraoz93 wants to merge 1 commit intoapache:mainfrom
bugraoz93:update-reproducible-checks-on-release-docs

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Jan 31, 2026

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Github Copilot to generate escape regexp on naming "s/..../g" replacement, which made it easier to add to the sed :)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jan 31, 2026
@bugraoz93 bugraoz93 mentioned this pull request Jan 31, 2026
Merged
1 task
@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Feb 1, 2026

Okay hint from Jens on other thread using diffoscope showed me some reasonable differents which only difference is rc1 in the local build for dependencies internally for providers. That is than okay to have the difference but I think we still should generate the local file as the same as release

potiuk
potiuk reviewed Feb 2, 2026
View reviewed changes
dev/README_RELEASE_AIRFLOW.md
do
echo "Checking if $(basename $i) is the same as ${AIRFLOW_REPO_ROOT}/dist/$(basename $i)"
diff "$(basename $i)" "${AIRFLOW_REPO_ROOT}/dist/$(basename $i)" && echo "OK"
# This conversion needed for how breeze creates packages and how we release them to keep things smooth
Copy link
Member

@potiuk potiuk Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack - strange you have it. The distributions that are stored in SVN (and those that you build locally for verification) - do not have RC suffix - currently we do not store rc suffixed distributions in SVN at all.

Probably you did export VERSION_SUFFIX=rc1

@potiuk
Copy link
Member

potiuk commented Feb 2, 2026

I know what the problem was (export VERSION_SUFFIX= instead of VERSION_SUFFIX=). Protection against such case added in #61352

Closing this one.

@potiuk potiuk closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk left review comments

@shahar1 shahar1 shahar1 approved these changes

@ashb ashb Awaiting requested review from ashb

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@kaxil kaxil Awaiting requested review from kaxil

@jason810496 jason810496 Awaiting requested review from jason810496

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees

No one assigned

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bugraoz93 @potiuk @shahar1