Skip to content

[AIRFLOW-5150] Implement POC for GitLab + Kubernetes tests - #6115

Closed
potiuk wants to merge 1 commit into
apache:masterfrom
PolideaInternal:test-gitlab-ci
Closed

potiuk wants to merge 1 commit into
apache:masterfrom
PolideaInternal:test-gitlab-ci

Conversation

@potiuk

@potiuk potiuk commented Sep 15, 2019

Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk mentioned this pull request Sep 15, 2019
5 of 6 tasks
@potiuk
potiuk force-pushed the test-gitlab-ci branch 5 times, most recently from f83f7e0 to 2de91e1 Compare September 16, 2019 00:50
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #6115 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6115      +/-   ##
==========================================
+ Coverage   79.98%   80.11%   +0.12%     
==========================================
  Files         607      607              
  Lines       34902    34902              
==========================================
+ Hits        27918    27963      +45     
+ Misses       6984     6939      -45
Impacted Files Coverage Δ
airflow/contrib/hooks/gcp_sql_hook.py 100% <ø> (ø) ⬆️
airflow/gcp/operators/automl.py 99.63% <ø> (ø) ⬆️
airflow/models/taskinstance.py 93.72% <0%> (+0.5%) ⬆️
airflow/jobs/scheduler_job.py 74.28% <0%> (+0.9%) ⬆️
airflow/utils/dag_processing.py 58.98% <0%> (+2.54%) ⬆️
airflow/executors/__init__.py 67.34% <0%> (+4.08%) ⬆️
airflow/utils/sqlalchemy.py 79.06% <0%> (+4.65%) ⬆️
airflow/utils/log/colored_log.py 93.18% <0%> (+11.36%) ⬆️
airflow/executors/sequential_executor.py 100% <0%> (+52.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca766b...1b597a7. Read the comment docs.

@feluelle feluelle added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Sep 20, 2019
@stale

stale Bot commented Nov 20, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 20, 2019
@potiuk

potiuk commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

This is waiting for GitLab (but I am slowly loosing my patience ;))

@stale stale Bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 21, 2019
@stale

stale Bot commented Jan 5, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 5, 2020
@potiuk

potiuk commented Jan 5, 2020

Copy link
Copy Markdown
Member Author

Probably won't need it eventually but I would like to keep it until we move to github actions

@stale stale Bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 5, 2020
@stale

stale Bot commented Feb 19, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 19, 2020
@stale stale Bot closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants