Skip to content

Fix language selector state not updating on change#61060

Merged
bbovenzi merged 1 commit intoapache:mainfrom
guan404ming:fix/language-selector-state-update
Jan 29, 2026
Merged

Fix language selector state not updating on change#61060
bbovenzi merged 1 commit intoapache:mainfrom
guan404ming:fix/language-selector-state-update

Conversation

@guan404ming
Copy link
Member

Why

Changing language didn't update the dropdown display because i18n.language isn't React state.

How

Added useState to track the selected language locally.
Calling setSelectedLang() after changeLanguage() completes triggers the re-render needed to update the UI.

before

Screen.Recording.2026-01-26.at.3.51.06.PM.mov

after

Screen.Recording.2026-01-26.at.3.47.09.PM.mov

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 26, 2026
@guan404ming guan404ming marked this pull request as ready for review January 26, 2026 10:01
kalluripradeep

This comment was marked as spam.

@bbovenzi bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Jan 29, 2026
@bbovenzi bbovenzi added this to the Airflow 3.1.8 milestone Jan 29, 2026
@bbovenzi bbovenzi merged commit 975cfe6 into apache:main Jan 29, 2026
146 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 975cfe6 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

sanchalitorpe-source pushed a commit to sanchalitorpe-source/airflow that referenced this pull request Jan 30, 2026
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jan 30, 2026

Needs manual backport just FYI @guan404ming @bbovenzi

guan404ming added a commit to guan404ming/airflow that referenced this pull request Jan 30, 2026
…e#61060)

(cherry picked from commit 975cfe6)

Co-authored-by: Guan-Ming (Wesley) Chiu <[email protected]>
@guan404ming
Copy link
Member Author

Thanks for your notification, just backported.

bbovenzi pushed a commit that referenced this pull request Jan 30, 2026
morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
ephraimbuddy pushed a commit that referenced this pull request Feb 3, 2026
potiuk pushed a commit that referenced this pull request Feb 3, 2026
* [v3-1-test] Add Keycloak token documentation to Security/API (#61228) (#61248)

(cherry picked from commit bb04b5d)

Co-authored-by: Bugra Ozturk <[email protected]>

* [v3-1-test] Fix language selector state not updating on change (#61060) (#61263)

(cherry picked from commit 975cfe6)

* [v3-1-test] Clarify template context for asset-triggered DAGs in airflow-core docs (#61258) (#61282)

(cherry picked from commit f7aa502)

Co-authored-by: Rachana Dutta <[email protected]>
Co-authored-by: kevinhongzl <[email protected]>

* [v3-1-test] Fix flaky OTel integration test with DNS health check (#61070) (#61242) (#61286)

* Fix flaky OTel integration test with DNS health check (#61070)

* Update airflow-core/tests/integration/otel/test_otel.py



---------
(cherry picked from commit 8ac25dd)

Co-authored-by: Abhishek Mishra <[email protected]>
Co-authored-by: Henry Chen <[email protected]>

* [v3-1-test] Update pmc verification docs (#61271) (#61294)

* Update Helm Chart release instructions for PMC Checks

* Update KEY download instructions for PMC Checks

* Update dev/README_RELEASE_HELM_CHART.md
(cherry picked from commit c74b24a)

* [v3-1-test] update version for release command (#61260) (#61328)

(cherry picked from commit 7790482)

Co-authored-by: Rahul Vats <[email protected]>

* CI: Upgrade important CI environment (#61327)

* [v3-1-test] Fix JWT token generation with unset issuer/audience config (#61278) (#61331)

* Fix JWT token generation with unset issuer/audience config
(cherry picked from commit a440d1d)

Co-authored-by: Amogh Desai <[email protected]>

* [v3-1-test] Remove empty `apache_airflow_site.py` file (#61308)
(cherry picked from commit d65ff01)

Co-authored-by: Jed Cunningham <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bugra Ozturk <[email protected]>
Co-authored-by: Guan-Ming (Wesley) Chiu <[email protected]>
Co-authored-by: Shahar Epstein <[email protected]>
Co-authored-by: Rachana Dutta <[email protected]>
Co-authored-by: kevinhongzl <[email protected]>
Co-authored-by: Abhishek Mishra <[email protected]>
Co-authored-by: Henry Chen <[email protected]>
Co-authored-by: Rahul Vats <[email protected]>
Co-authored-by: Amogh Desai <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants