added UI E2E Tests for Connections Page #60569#60738
added UI E2E Tests for Connections Page #60569#60738vatsrahul1001 merged 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@vishakha1411 Thanks for the PR. I will review soon |
|
I fixed the failing errors and removed redundant cross-browser compatibility tests. Since Playwright already executes the full test suite across all supported browsers, these tests were unnecessary. Please check now. |
Thanks @vishakha1411 I will review soon |
efaf5f3 to
a60727b
Compare
|
@vatsrahul1001 I noticed some static checks failed. I tried to fix them by explicitly handling nullable string values, changing null to undefined for consistency, and fixing naming conventions. Hope it works now, please check! |
airflow-core/src/airflow/ui/tests/e2e/specs/connections.spec.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/specs/connections.spec.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/specs/connections.spec.ts
Outdated
Show resolved
Hide resolved
|
@vishakha1411 Great first PR! there are several alignment issues with our existing patterns that need to be addressed specifically in pagination and filter/search tests. I suggest to you look at how these are implemented for other pages. |
|
@vatsrahul1001 I have made the changes you pointed out. Key Changes
|
b719774 to
3339adf
Compare
|
@vatsrahul1001 @choo121600 I noticed that a few CRUD tests are failing on Chromium in CI, while the same tests pass on Firefox and WebKit. All tests are also passing locally for all browsers. |
@vishakha1411 As per the stacktrace from failure I see even after clicking on edit button edit form is not visible as per failure screenshot For debugging purposes, always try to look at the failure report. You can download the report from upload result steps. There could be two issues here: either the edit button is not getting clicked correctly, or it's taking time to open the edit button. Yes, you can try increasing the timeout, and also confirm if the edit button is getting clicked correctly or not. As you mentioned, it works locally fine, but I still suggest trying running test in UI mode, you can --ui-mode in breeze test command arg. It helps a lot in debugging |
d8d8695 to
fd3f1e4
Compare
|
@vishakha1411 How are we progressing on this? |
@vatsrahul1001 I made a few fixes to address the flaky tests. All the tests pass now. Please review and let me know if any changes are required. |
Thanks @vishakha1411 I will review soon! |
airflow-core/src/airflow/ui/tests/e2e/specs/connections.spec.ts
Outdated
Show resolved
Hide resolved
|
@vishakha1411 can you look at failing tests? Also lets remove pagination and sorting test as discussed in comment. We will cover all testing behaviour in react unit tests |
8fc50b1 to
eb613c5
Compare
|
@vatsrahul1001 I have fixed the failing tests and have removed the pagination and sorting tests as suggested. All the tests pass now. |
|
Nice!. |

Description
Adds comprehensive end-to-end tests for the Connections page (
/connections) following the Page Object Model pattern.Test Coverage
Note: The Connections UI does not currently provide an export action or button. Exporting connections is supported via CLI/API only, so this behavior cannot be validated through UI-based E2E tests.
Testing Status
✅ Verified locally across Chromium, Firefox, and WebKit
Technical Highlights
beforeAll/afterAlltestConfigfor configurationAcceptance Criteria Met
testConfigfor configurationPlease let me know your suggestions, happy to make any changes if needed!
In case of an existing issue, reference it using one of the following: