feat: Add E2E tests for Task Instances page#60514
Merged
vatsrahul1001 merged 9 commits intoapache:mainfrom Feb 5, 2026
Merged
Conversation
airflow-core/src/airflow/ui/tests/e2e/specs/task-instances.spec.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
- Use URL parameters (?task_state=) instead of UI interactions for filtering - Simplify pagination verification using semantic button selectors - Replace regex-based text parsing with Playwright's getByRole() - Use or() pattern for cleaner conditional logic
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks, @lin121291 for implementing review comments. I suggest resolving comments after you are done. I will review this soon |
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Pagination needs to follow the established pattern from PR #59400: The current implementation differs from our merged pagination tests. Please reference:
// Reference pattern (from DagsPage.ts)
|
Address review feedback from PR apache#59400: - Use data-testid selectors instead of page numbers - Remove conditional checks for pagination - Verify data actually changes with expect.poll()
Contributor
Author
|
@vatsrahul1001 Fixed! Now following the DagsPage pattern from PR #59400:
Thanks !! |
vatsrahul1001
approved these changes
Feb 5, 2026
Contributor
Nice! |
Alok-kumar-priyadarshi
pushed a commit
to Alok-kumar-priyadarshi/airflow
that referenced
this pull request
Feb 5, 2026
* feat: Add E2E tests for Task Instances page Co-authored-by: Rahul Vats <[email protected]>
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
* feat: Add E2E tests for Task Instances page Co-authored-by: Rahul Vats <[email protected]>
Ratasa143
pushed a commit
to Ratasa143/airflow
that referenced
this pull request
Feb 15, 2026
* feat: Add E2E tests for Task Instances page Co-authored-by: Rahul Vats <[email protected]>
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
* feat: Add E2E tests for Task Instances page Co-authored-by: Rahul Vats <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds end-to-end (E2E) tests for the Task Instances page (/task_instances) to improve test coverage of the UI.
What does this PR do?
New Files:
airflow-core/src/airflow/ui/tests/e2e/pages/TaskInstancesPage.ts- Page Object Model for Task Instances pageairflow-core/src/airflow/ui/tests/e2e/specs/task-instances.spec.ts- Test specificationsRelated Issues
Closes #59357