Skip to content

feat : E2E test to verify required action page#60449

Merged
vatsrahul1001 merged 31 commits intoapache:mainfrom
iharsh02:verify-required-action-page
Jan 28, 2026
Merged

feat : E2E test to verify required action page#60449
vatsrahul1001 merged 31 commits intoapache:mainfrom
iharsh02:verify-required-action-page

Conversation

@iharsh02
Copy link
Contributor

Verify required action page

  • navigate to required action page /required_actions
  • Verify the actions list/table is displayed (or empty state if none)
  • Verify pagination
  • verify action details

closes: #59934
related: #59028

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 13, 2026
@iharsh02
Copy link
Contributor Author

3de0d99943cb2d3aeb333f05c9eb2b0a0e6ab893 @vatsrahul1001 For some reason in ci after clicking on approve in valid_input_options task the rest of the task is getting skipped , as seen in logs Task was skipped - no logs available. ?

Why is it like that can you help with this ?

works fine on local

@vatsrahul1001
Copy link
Contributor

3de0d99943cb2d3aeb333f05c9eb2b0a0e6ab893 @vatsrahul1001 For some reason in ci after clicking on approve in valid_input_options task the rest of the task is getting skipped , as seen in logs Task was skipped - no logs available. ?
Why is it like that can you help with this ?

works fine on local

Maybe instead of approving HITL flow in CI its rejecting due to which downstream tasks are getting skipped

@iharsh02
Copy link
Contributor Author

3de0d99943cb2d3aeb333f05c9eb2b0a0e6ab893 @vatsrahul1001 For some reason in ci after clicking on approve in valid_input_options task the rest of the task is getting skipped , as seen in logs Task was skipped - no logs available. ?
Why is it like that can you help with this ?

works fine on local

Maybe instead of approving HITL flow in CI its rejecting due to which downstream tasks are getting skipped

Working on a fix let you know when done

@vatsrahul1001
Copy link
Contributor

@iharsh02 how are we progressing on this?

@iharsh02
Copy link
Contributor Author

@iharsh02 how are we progressing on this?

I had increased the HITL execution timeout from 1 min to 5min (1min timeframe for HITL to execute in ci is slow that's why it was getting skipped)

The test not longer getting skipped, but still in deffered state , which I am still figuring out

@vatsrahul1001
Copy link
Contributor

@iharsh02 how are we progressing on this?

I had increased the HITL execution timeout from 1 min to 5min (1min timeframe for HITL to execute in ci is slow that's why it was getting skipped)

The test not longer getting skipped, but still in deffered state , which I am still figuring out

It's in deferred state because you have not approved or rejected task from the required action tab. If you approve it tasks succeeds; if you reject than all downstream task skips

@iharsh02
Copy link
Contributor Author

@iharsh02 how are we progressing on this?

I had increased the HITL execution timeout from 1 min to 5min (1min timeframe for HITL to execute in ci is slow that's why it was getting skipped)
The test not longer getting skipped, but still in deffered state , which I am still figuring out

It's in deferred state because you have not approved or rejected task from the required action tab. If you approve it tasks succeeds; if you reject than all downstream task skips

image In CI it shows the button clicked , is there any other reason the state of dag is being deferred ?

@vatsrahul1001
Copy link
Contributor

@iharsh02 how are we progressing on this?

I had increased the HITL execution timeout from 1 min to 5min (1min timeframe for HITL to execute in ci is slow that's why it was getting skipped)
The test not longer getting skipped, but still in deffered state , which I am still figuring out

It's in deferred state because you have not approved or rejected task from the required action tab. If you approve it tasks succeeds; if you reject than all downstream task skips

image In CI it shows the button clicked , is there any other reason the state of dag is being deferred ?

Looks like CI tried clicking but maybe it did not clicked. One thing to can try is to use HITL API to approve and see if it fixes for you just to verify

@iharsh02
Copy link
Contributor Author

@vatsrahul1001 test user(airflow) was not in the assigned user in the example_hitl_dag , so we were getting 403 when we were trying to approve the task

Fixed

@vatsrahul1001
Copy link
Contributor

@vatsrahul1001 test user(airflow) was not in the assigned user in the example_hitl_dag , so we were getting 403 when we were trying to approve the task

Fixed

Great work!

@vatsrahul1001 vatsrahul1001 merged commit 7decec2 into apache:main Jan 28, 2026
128 checks passed
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
feat : E2E test to verify required action page

Co-authored-by: Rahul Vats <[email protected]>
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
feat : E2E test to verify required action page

Co-authored-by: Rahul Vats <[email protected]>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
feat : E2E test to verify required action page

Co-authored-by: Rahul Vats <[email protected]>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
feat : E2E test to verify required action page

Co-authored-by: Rahul Vats <[email protected]>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
feat : E2E test to verify required action page

Co-authored-by: Rahul Vats <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI E2E Test || BROWSE-005: Verify Required Actions Page

2 participants