@vatsrahul1001 can you take a look. Builds are passing now. Thanks

Thanks, I will review it soon!

@Prajwal7842 Thanks for the PR! A few things to address:

1. Test naming - Remove "should" prefix (use "verify ..." instead of "should verify ...")

2. Remove hardcoded waits - waitForTimeout(5000) is slow and fragile. Use proper Playwright assertions:
   await expect(async () => {
   const indicator = await eventsPage.getColumnSortIndicator(0);
   expect(indicator).not.toBe("none");
   }).toPass({ timeout: 10_000 });

3. Move DAG trigger to beforeAll - Current "Events with Generated Data" tests depend on first test running. Move triggerDag to beforeAll for proper isolation

4. Column selectors are fragile - Using .nth(1), .nth(2) breaks if column order changes. Use text/role-based selectors:
   this.eventTypeColumn = page.getByRole("columnheader", { name: /event/i });
   5. Sorting test weak - Only checks indicator, not actual sort order. Capture data before/after and verify it changed

5. Filter test incomplete - Only opens menu, doesn't apply filter. Add test that applies filter and verifies results

6. Fix pagination URL - Missing / prefix and limit=1 is too small:
   return "/events?limit=5&offset=0";
   8. Remove waitForTimeout method

Let me know if you have questions!

@Prajwal7842 Thanks for the PR! A few things to address:

1. Test naming - Remove "should" prefix (use "verify ..." instead of "should verify ...")
2. Remove hardcoded waits - waitForTimeout(5000) is slow and fragile. Use proper Playwright assertions:
   await expect(async () => {
   const indicator = await eventsPage.getColumnSortIndicator(0);
   expect(indicator).not.toBe("none");
   }).toPass({ timeout: 10_000 });
3. Move DAG trigger to beforeAll - Current "Events with Generated Data" tests depend on first test running. Move triggerDag to beforeAll for proper isolation
4. Column selectors are fragile - Using .nth(1), .nth(2) breaks if column order changes. Use text/role-based selectors:
   this.eventTypeColumn = page.getByRole("columnheader", { name: /event/i });
   5. Sorting test weak - Only checks indicator, not actual sort order. Capture data before/after and verify it changed
5. Filter test incomplete - Only opens menu, doesn't apply filter. Add test that applies filter and verifies results
6. Fix pagination URL - Missing / prefix and limit=1 is too small:
   return "/events?limit=5&offset=0";
   8. Remove waitForTimeout method

Let me know if you have questions!

Thanks @vatsrahul1001 for the review. I have addressed the comments.
For point (5), regarding integration tests for filter, I am working on it in the follow up diff. Thanks.

@Prajwal7842 #59734 is already merged now. Can you rebase. I think you can reuse alot of code

@Prajwal7842 How are we progressing on this?

@Prajwal7842 How are we progressing on this?

#59931 (comment)

@vatsrahul1001 updated the tests as per suggestions. PTAL. Thanks

Thanks @Prajwal7842 I will review soon

@Prajwal7842 I see tests are failing. can you check?

@Prajwal7842 I see tests are failing. can you check?

Just updating: These tests are passing for me locally without any flakiness for some reason (passing on repeated tries), hence taking more time to debug this.

@Prajwal7842 I see tests are failing. can you check?

Just updating: These tests are passing for me locally without any flakiness for some reason (passing on repeated tries), hence taking more time to debug this.

I suggest to check failure report and look where it is failing

@Prajwal7842 any progress on this?

@Prajwal7842 any progress on this?

Hi, I missed this, I will get back by tomorrow on this and update here.

Hi @vatsrahul1001 can you check the PR. The tests are passing now.
What I did to fix was :
Previouly, the code was trying to compare the before and after arrays when the sorting button was clicked.
Now, the code just takes the final array and checks that the array is sorted.

Hi @vatsrahul1001 can you check the PR. The tests are passing now. What I did to fix was : Previouly, the code was trying to compare the before and after arrays when the sorting button was clicked. Now, the code just takes the final array and checks that the array is sorted.

Thanks for all your efforts @Prajwal7842 , however, as discussed here we are planning not to include sort and pgaination tests in E2E. Can you remove them

Hi @vatsrahul1001 can you check the PR. The tests are passing now. What I did to fix was : Previouly, the code was trying to compare the before and after arrays when the sorting button was clicked. Now, the code just takes the final array and checks that the array is sorted.

Thanks for all your efforts @Prajwal7842 , however, as discussed here we are planning not to include sort and pgaination tests in E2E. Can you remove them

Hi @vatsrahul1001 I have updated the file and removed pagination/sorting tests. Tests are passing as well. Requesting a review. Thanks

Hi @vatsrahul1001 can you check the PR. The tests are passing now. What I did to fix was : Previouly, the code was trying to compare the before and after arrays when the sorting button was clicked. Now, the code just takes the final array and checks that the array is sorted.

Thanks for all your efforts @Prajwal7842 , however, as discussed here we are planning not to include sort and pgaination tests in E2E. Can you remove them

Hi @vatsrahul1001 I have updated the file and removed pagination/sorting tests. Tests are passing as well. Requesting a review. Thanks

Nice!