Test(UI): Add E2E tests for Asset Details by junaiddshaukat · Pull Request #59939 · apache/airflow

junaiddshaukat · 2025-12-30T17:29:07Z

This adds Page Object and specs for verifying the Asset Details page, covering producing tasks and consuming DAGs validation.

This PR adds Playwright UI E2E coverage for the Asset Details page.
Adds a page object (AssetsPage) for navigating Assets and asserting details/dependencies.
Adds an E2E spec verifying an asset’s details include producing tasks and scheduled DAGs.
closes: #59930

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

boring-cyborg · 2025-12-30T17:29:17Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: [email protected]
Slack: https://s.apache.org/airflow-slack

junaiddshaukat · 2025-12-30T17:31:26Z

@vatsrahul1001 Please have a look on this PR, I have tested it well with breeze testing and prek. If need any changes, let me know!

vatsrahul1001 · 2026-01-02T09:59:11Z

junaiddshaukat

@vatsrahul1001 Please have a look on this PR, I have tested it well with breeze testing and prek. If need any changes, let me know!

@junaiddshaukat Thanks for the PR. I will review it soon.

vatsrahul1001 · 2026-01-06T13:55:52Z

@junaiddshaukat Thanks for the PR! A few things to address:

Coordinate with PR Test: Add E2E tests for Assets Page #59990 - Both PRs create different files for assets. Work together to use single AssetsPage.ts
Add beforeAll for data setup - Tests assume asset exists with producing tasks. Add setup to trigger asset_produces_1 DAG and unpause consumer
Fix fragile selectors:
- label.locator("..") relies on DOM structure
- .chakra-popover__body is framework-specific
Test naming - Use "verify" prefix without "should"
Remove unused code - assetsTable locator is never used
Refactor duplicate code - verifyProducingTasks and verifyScheduledDags are nearly identical

Let me know if you have questions!

airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts

airflow-core/src/airflow/ui/tests/e2e/pages/AssetsPage.ts

airflow-core/src/airflow/ui/tests/e2e/pages/AssetDetailPage.ts

junaiddshaukat · 2026-01-07T07:50:20Z

@vatsrahul1001, Thanks for review. I am working on it will update soon

vatsrahul1001 · 2026-01-14T09:05:38Z

@junaiddshaukat #59990 has been merged. Let's rebase and reuse that

junaiddshaukat · 2026-01-14T09:08:16Z

@junaiddshaukat #59990 has been merged. Let's rebase and reuse that

Sure, I will rebase and resue that and fix this PR. Will update you on it soon. thanks

This adds Page Object and specs for verifying the Asset Details page, covering producing tasks and consuming DAGs validation. Signed-off-by: junaiddshaukat <[email protected]>

- Rename AssetsPage to AssetDetailPage for clarity (coordinates with apache#59990) - Add beforeAll to trigger asset_produces_1 DAG before tests - Fix fragile selectors (use parent container + ARIA roles) - Refactor duplicate code into verifyStatSection helper - Remove unused assetsTable locator - Rename test to remove 'should' prefix - Change describe name to 'Asset Details Page'

junaiddshaukat · 2026-01-15T14:11:37Z

Hi @vatsrahul1001, thanks for the detailed review! I've addressed all your feedback:

Changes Made:

Coordinated with PR Test: Add E2E tests for Assets Page #59990 - Renamed AssetsPage.ts → AssetDetailPage.ts to clearly distinguish from the merged AssetListPage.ts. Also renamed the test describe to "Asset Details Page".
Added beforeAll for data setup - Added setup that triggers asset_produces_1 DAG and polls for completion before tests run, ensuring asset data exists in CI.
Fixed fragile selectors:
- Replaced label.locator("..") with label.locator("xpath=./parent::*") + .first()
- Replaced .chakra-popover__body with getByRole("dialog").getByRole("link")
Test naming - Changed to "verify asset details and dependencies" (removed "should")
Removed unused code - Removed the assetsTable locator
Refactored duplicate code - Created verifyStatSection() helper method used by both verifyProducingTasks() and verifyScheduledDags()

Tests pass locally on Chromium and WebKit. Ready for re-review! Please have a look and if need any furthur changes let me know!

vatsrahul1001 · 2026-01-18T19:12:06Z

Hi @vatsrahul1001, thanks for the detailed review! I've addressed all your feedback:

Changes Made:

Coordinated with PR Test: Add E2E tests for Assets Page #59990 - Renamed AssetsPage.ts → AssetDetailPage.ts to clearly distinguish from the merged AssetListPage.ts. Also renamed the test describe to "Asset Details Page".

Added beforeAll for data setup - Added setup that triggers asset_produces_1 DAG and polls for completion before tests run, ensuring asset data exists in CI.

Fixed fragile selectors:

Replaced label.locator("..") with label.locator("xpath=./parent::*") + .first()

Replaced .chakra-popover__body with getByRole("dialog").getByRole("link")

Test naming - Changed to "verify asset details and dependencies" (removed "should")

Removed unused code - Removed the assetsTable locator

Refactored duplicate code - Created verifyStatSection() helper method used by both verifyProducingTasks() and verifyScheduledDags()

Tests pass locally on Chromium and WebKit. Ready for re-review! Please have a look and if need any furthur changes let me know!

@junaiddshaukat Thanks I will review soon

airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts

vatsrahul1001 · 2026-01-26T11:52:00Z

Hi @vatsrahul1001, thanks for the detailed review! I've addressed all your feedback:

Changes Made:

Coordinated with PR Test: Add E2E tests for Assets Page #59990 - Renamed AssetsPage.ts → AssetDetailPage.ts to clearly distinguish from the merged AssetListPage.ts. Also renamed the test describe to "Asset Details Page".

Added beforeAll for data setup - Added setup that triggers asset_produces_1 DAG and polls for completion before tests run, ensuring asset data exists in CI.

Fixed fragile selectors:

Replaced label.locator("..") with label.locator("xpath=./parent::*") + .first()

Replaced .chakra-popover__body with getByRole("dialog").getByRole("link")

Test naming - Changed to "verify asset details and dependencies" (removed "should")

Removed unused code - Removed the assetsTable locator

Refactored duplicate code - Created verifyStatSection() helper method used by both verifyProducingTasks() and verifyScheduledDags()

Tests pass locally on Chromium and WebKit. Ready for re-review! Please have a look and if need any furthur changes let me know!

@junaiddshaukat Thanks I will review soon

Thanks @junaiddshaukat great work here. I see we have created a new spec page for asset, however we already have existing asset spec page I suggest you to add your test in same spec file and reuse the code

- Add asset.name to testConfig in playwright.config.ts - Merge asset detail test into existing asset.spec.ts (reuse beforeAll) - Use testConfig.asset.name instead of hardcoded values - Remove duplicate assets.spec.ts file

junaiddshaukat · 2026-01-26T16:29:41Z

Hi @vatsrahul1001, thanks for the feedback! I've made the requested changes:

Merged test into existing asset.spec.ts - Added the asset detail test to the existing spec file instead of a separate file
Reusing existing beforeAll - The test now uses the existing beforeAll setup that triggers asset_produces_1
Using config for asset name - Added testConfig.asset.name in playwright.config.ts and updated both the search test and detail test to use it
Removed assets.spec.ts - Deleted the duplicate spec file

The AssetDetailPage.ts page object is still used for the detail page verification methods.

Ready for re-review!

vatsrahul1001 · 2026-01-28T04:48:53Z

Great work @junaiddshaukat, good to be merged

Add E2E tests for Asset Details Signed-off-by: junaiddshaukat <[email protected]> Co-authored-by: Rahul Vats <[email protected]>

junaiddshaukat requested a review from vatsrahul1001 as a code owner December 30, 2025 17:29

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 30, 2025

junaiddshaukat mentioned this pull request Jan 1, 2026

UI E2E Test || ASSET-002: Verify Asset Details Display #59930

Closed

7 tasks

vatsrahul1001 mentioned this pull request Jan 6, 2026

Test: Add E2E tests for Assets Page #59990

Merged

vatsrahul1001 reviewed Jan 6, 2026

View reviewed changes

junaiddshaukat added 2 commits January 15, 2026 15:52

Test(UI): Add E2E tests for Asset Details

a58f767

This adds Page Object and specs for verifying the Asset Details page, covering producing tasks and consuming DAGs validation. Signed-off-by: junaiddshaukat <[email protected]>

junaiddshaukat force-pushed the test/ui-asset-details branch from e2e4374 to cfa9014 Compare January 15, 2026 14:08

junaiddshaukat requested a review from choo121600 as a code owner January 15, 2026 14:08

Merge branch 'main' into test/ui-asset-details

0e4c76e

Merge branch 'main' into test/ui-asset-details

81b6981

vatsrahul1001 reviewed Jan 26, 2026

View reviewed changes

airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts Outdated Show resolved Hide resolved

airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts Outdated Show resolved Hide resolved

airflow-core/src/airflow/ui/tests/e2e/specs/assets.spec.ts Outdated Show resolved Hide resolved

junaiddshaukat and others added 2 commits January 26, 2026 21:10

Merge branch 'main' into test/ui-asset-details

09b3a10

refactor: merge asset detail test into existing asset.spec.ts

5712cb7

- Add asset.name to testConfig in playwright.config.ts - Merge asset detail test into existing asset.spec.ts (reuse beforeAll) - Use testConfig.asset.name instead of hardcoded values - Remove duplicate assets.spec.ts file

junaiddshaukat requested review from bbovenzi, guan404ming, pierrejeambrun, ryanahamilton and shubhamraj-git as code owners January 26, 2026 16:29

Merge branch 'main' into test/ui-asset-details

644efcb

vatsrahul1001 approved these changes Jan 28, 2026

View reviewed changes

vatsrahul1001 merged commit 323bc16 into apache:main Jan 28, 2026
77 checks passed

shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026

Test(UI): Add E2E tests for Asset Details (apache#59939)

ab31754

Add E2E tests for Asset Details Signed-off-by: junaiddshaukat <[email protected]> Co-authored-by: Rahul Vats <[email protected]>

shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026

Test(UI): Add E2E tests for Asset Details (apache#59939)

4060cc2

Add E2E tests for Asset Details Signed-off-by: junaiddshaukat <[email protected]> Co-authored-by: Rahul Vats <[email protected]>

choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026

Test(UI): Add E2E tests for Asset Details (apache#59939)

8dc24a0

Add E2E tests for Asset Details Signed-off-by: junaiddshaukat <[email protected]> Co-authored-by: Rahul Vats <[email protected]>

Conversation

junaiddshaukat commented Dec 30, 2025

Uh oh!

boring-cyborg bot commented Dec 30, 2025

Uh oh!

junaiddshaukat commented Dec 30, 2025

Uh oh!

vatsrahul1001 commented Jan 2, 2026

Uh oh!

vatsrahul1001 commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junaiddshaukat commented Jan 7, 2026

Uh oh!

vatsrahul1001 commented Jan 14, 2026

Uh oh!

junaiddshaukat commented Jan 14, 2026

Uh oh!

junaiddshaukat commented Jan 15, 2026

Changes Made:

Uh oh!

vatsrahul1001 commented Jan 18, 2026

Changes Made:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vatsrahul1001 commented Jan 26, 2026

Changes Made:

Uh oh!

junaiddshaukat commented Jan 26, 2026

Uh oh!

vatsrahul1001 commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants