Skip to content

Conversation

@ewljmgzbyydh123
Copy link
Contributor

@ewljmgzbyydh123 ewljmgzbyydh123 commented Aug 10, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Set autodetect default value from false to be true to avoid breaking downstream services using GoogleCloudStorageToBigQueryOperator but not aware of the newly added autodetect field. This PR is to fix the current regression introduced by #3880

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@ewljmgzbyydh123 ewljmgzbyydh123 changed the title [AIRFLOW-5152] Fix autodetect default value from False to True in Goo… [AIRFLOW-5152] Fix autodetect default value from False to True. Aug 10, 2019
@ewljmgzbyydh123 ewljmgzbyydh123 changed the title [AIRFLOW-5152] Fix autodetect default value from False to True. [AIRFLOW-5152] Fix autodetect default value from False to be True Aug 10, 2019
@ewljmgzbyydh123
Copy link
Contributor Author

Had to decline #5764 and open a new one since I messed up the commit messages in the previous one.

@ashb ashb changed the title [AIRFLOW-5152] Fix autodetect default value from False to be True [AIRFLOW-5152] Fix GoogleCloudStorageToBigQueryOperator autodetect default value from False to be True Aug 16, 2019
@ashb ashb merged commit 462ab88 into apache:master Aug 16, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Aug 20, 2019
…e in GoogleCloudStorageToBigQueryOperator. (apache#5771)

Set autodetect default value from false to be true to avoid breaking downstream
services using GoogleCloudStorageToBigQueryOperator but not aware of the newly
added autodetect field.

This is to fix the current regression introduced by apache#3880

(cherry picked from commit 462ab88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants