Skip to content

fix: show appropriate time units in grid view#56403

Merged
jscheffl merged 2 commits into
apache:mainfrom
RoyLee1224:grid-duration
Oct 5, 2025
Merged

fix: show appropriate time units in grid view#56403
jscheffl merged 2 commits into
apache:mainfrom
RoyLee1224:grid-duration

Conversation

@RoyLee1224

Copy link
Copy Markdown
Contributor

Related

part of #56250

Why

The grid dag timing seems to always be in terms of seconds

Screenshots

duration_before duration_after

Notes

We would need to remove all of the translation keys for "seconds"


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 5, 2025

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jscheffl

jscheffl commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

Note before merging: Can you check whether the translation key "seconds" is used in anotherplace and prune it from all translations if this is the last usage?

@RoyLee1224

RoyLee1224 commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

1. Confirmed: The translation key seconds is not used in other places

CleanShot 2025-10-05 at 12 25 48

2. Remove seconds translation key in all files

Before
CleanShot 2025-10-05 at 12 32 52
After
CleanShot 2025-10-05 at 12 30 26

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me! Thanks for cleaning the translation.

@jscheffl jscheffl added this to the Airflow 3.1.1 milestone Oct 5, 2025
@jscheffl jscheffl merged commit f10c905 into apache:main Oct 5, 2025
59 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 5, 2025
* fix: show appropriate time units in grid view

* i18n: remove second translation keys
(cherry picked from commit f10c905)

Co-authored-by: LI,JHE-CHEN <[email protected]>
@github-actions

github-actions Bot commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

jscheffl pushed a commit that referenced this pull request Oct 5, 2025
…56414)

* fix: show appropriate time units in grid view

* i18n: remove second translation keys
(cherry picked from commit f10c905)

Co-authored-by: LI,JHE-CHEN <[email protected]>
@RoyLee1224 RoyLee1224 deleted the grid-duration branch October 5, 2025 21:36
@NilsJPWerner NilsJPWerner mentioned this pull request Oct 6, 2025
19 tasks
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
* fix: show appropriate time units in grid view

* i18n: remove second translation keys
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
* fix: show appropriate time units in grid view

* i18n: remove second translation keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants