fix: corrects issues with edge rendering on the graph view#53998
Conversation
831a266 to
047805a
Compare
047805a to
b5dd3fd
Compare
|
Thanks for the PR, indeed that need fixing. |
There was a problem hiding this comment.
Instead of doing another full pass on filteredEdges and creating another big list of edges with many duplicated, move this deduplication step directly in the formatChildNode function. This will allow to not insert duplicated edges at all in the first place, removing the need for an extra step in the process.
The deduplication logic has been moved to |
a09af91 to
f6a991a
Compare
#53998) * fix: corrects issues with edge rendering on the graph view * fix: moved edge deduplication logic to formatChildNode. --------- (cherry picked from commit 7f8383b) Co-authored-by: codecae <[email protected]> Co-authored-by: Curtis Bangert <[email protected]>
#53998) (#54412) * fix: corrects issues with edge rendering on the graph view * fix: moved edge deduplication logic to formatChildNode. --------- (cherry picked from commit 7f8383b) Co-authored-by: codecae <[email protected]> Co-authored-by: Curtis Bangert <[email protected]>
closes: #35301
The graph UI has issues rendering edges between dependent tasks nested in task groups. Edges render with excessive bends in various directions instead of directly between tasks and their parents task groups as they are collapsed and expanded. They also tend to render vertically off center at node borders. This PR addresses this edge rendering issue.
Example code that reproduces the issue:
Rendering issue examples:





With this fix:





