More robust handling of BaseHook.get_connection's CONNECTION_NOT_FOUND Task SDK exception#52838
Merged
ferruzzi merged 1 commit intoapache:mainfrom Jul 4, 2025
Conversation
…OUND` Task SDK exception After apache#51873, the base hook's `get_connection` exception for when connection is not found was changed and was no longer being caught by `AwsGenericHook`. This change fixes that by using a robust approach. At some point, we should probably make the connection getter raise exceptions in a more consistent manner, maybe once we fully switch over to Task SDK.
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
Author
|
cc @ferruzzi |
amoghrajesh
reviewed
Jul 4, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
@ramitkataria it might take me some time to balance my priorities and get similar handling for v3 vs v2 exception wise as I do not want to hurry into it.
Could you leave a comment with # TODO: amoghrajesh or just a general todo for me?
Let me know if you want an approval on this in the meantime to unblock your system tests.
1 task
ferruzzi
approved these changes
Jul 4, 2025
amoghrajesh
approved these changes
Jul 4, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM based on my last comment.
Will look at better handling next week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #51873, the base hook's
get_connectionexception for when connection is not found was changed and was no longer being caught byAwsGenericHook. This change fixes that by using a robust approach.At some point, we should probably make the connection getter raise exceptions in a more consistent manner, maybe once we fully switch over to Task SDK.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.