Add docs for edge execution_api_server_url#52082
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:edge
|
@jscheffl If you agree with the alternative implementation I described above, I would be happy to open another PR for it. |
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for documenting. I never came across this - problably as I always configured correctly.
Other than docs we could also force to set it "better" for example in https://github.com/apache/airflow/blob/main/providers/edge3/src/airflow/providers/edge3/cli/edge_command.py#L81 so that if this is not properly set that we "guess" and assume is is the same base like the edge API URL (which is the same base in 99% of cases...)
That is what I mentioned here, should I open a PR for that? |
If you like that would be cool! |
3 participants
The
EdgeExecutordefaults tolocalhost:8080forcore.execution_api_server_url, which does not immediately fail, but causes errors once a job is dequeued.The newly added documentation guides users on how to properly configure
core.execution_api_server_url.Alternatively, the implementation logic itself could be improved by deriving the value from
edge.api_urlinstead.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.