Skip to content

[AIRFLOW-4255] Replace Discovery based api with client based for GCS #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 12 commits into from
Apr 9, 2019
Merged

[AIRFLOW-4255] Replace Discovery based api with client based for GCS #5054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dc16fc5
[AIRFLOW-4255] Replaces Discovery based api with client based for GCS
kaxil Apr 7, 2019
bca3d0b
Add tests
kaxil Apr 8, 2019
60e0d01
GCS Download corrections
kaxil Apr 8, 2019
c66ee86
Update test_gcs_hook.py
kaxil Apr 8, 2019
681cfc8
Fix test
kaxil Apr 8, 2019
dbbf54a
Update Bucket -> get_bucket
kaxil Apr 8, 2019
e3b6bdf
Update UPDATING.md
kaxil Apr 8, 2019
81d8837
Update UPDATING.md
kaxil Apr 8, 2019
10615ff
Update version
kaxil Apr 8, 2019
772944b
Update gcs_hook.py
kaxil Apr 8, 2019
44b5e44
Update UPDATING.md
kaxil Apr 8, 2019
d0739e1
Merge branch 'master' into replace-gcs-client-library
kaxil Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,28 @@ assists users migrating to a new version.

## Airflow Master

### Changes to GoogleCloudStorageHook

* the discovery-based api (`googleapiclient.discovery`) used in `GoogleCloudStorageHook` is now replaced by the recommended client based api (`google-cloud-storage`). To know the difference between both the libraries, read https://cloud.google.com/apis/docs/client-libraries-explained. PR: [#5054](https://github.com/apache/airflow/pull/5054)
* as a part of this replacement, the `multipart` & `num_retries` parameters for `GoogleCloudStorageHook.upload` method has been removed:

**Old**:
```python
def upload(self, bucket, object, filename,
mime_type='application/octet-stream', gzip=False,
multipart=False, num_retries=0):
```

**New**:
```python
def upload(self, bucket, object, filename,
mime_type='application/octet-stream', gzip=False):
```

The client library uses multipart upload automatically if the object/blob size is more than 8 MB - [source code](https://github.com/googleapis/google-cloud-python/blob/11c543ce7dd1d804688163bc7895cf592feb445f/storage/google/cloud/storage/blob.py#L989-L997).

* the `generation` parameter is no longer supported in `GoogleCloudStorageHook.delete` and `GoogleCloudStorageHook.insert_object_acl`.

### Changes to CloudantHook

* upgraded cloudant version from `>=0.5.9,<2.0` to `>=2.0`
Expand Down
Loading