Migrate ElasticsearchSQLHook to use get_df#50454
Merged
eladkal merged 2 commits intoapache:mainfrom May 11, 2025
Merged
Conversation
Member
Author
|
This is the last one of the whole migration! |
16 tasks
eladkal
reviewed
May 11, 2025
providers/elasticsearch/src/airflow/providers/elasticsearch/hooks/elasticsearch.py
Show resolved
Hide resolved
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py
Show resolved
Hide resolved
Member
Author
|
BTW should we also bump other packages using |
eladkal
approved these changes
May 11, 2025
Contributor
We bump min version when there is a reason.. otherwise we will always have latest version as minimum. |
Member
Author
|
Sure, thanks for the answer and it does make sense. Also thanks for the review and suggestions. |
Member
Author
|
Thanks! |
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Migrate `ElasticsearchSQLHook` to use `get_df` * Add todo comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
get_pandas_dftoget_dfinproviders#49334cc: @eladkal
Why
get_pandas_dfdeprecated in #48875, which would be replaced byget_df. Thus, we need to migrate them in providers.How
After investigation, I found that
ElasticsearchSQLHookhas its ownElasticsearchSQLCursorwhich is not compatable with polars cursor execution since there is a abstraction for cursor execution when callingpolars.read_database.reference: polars.read_database and the abstraction called _executor _executor
Also there is nothing about the integration info on polars IO document and Elasticsearch document thus I thought it would be better to raise
NotImplementedErrorfor it like we did in #50017.Minor change: migrate to
common-sql1.27.0 to have betterget_dftype def^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.