nit: Remove duplicate warning when no OL metadata returned#50350
Merged
mobuchowski merged 1 commit intoapache:mainfrom May 9, 2025
Merged
nit: Remove duplicate warning when no OL metadata returned#50350mobuchowski merged 1 commit intoapache:mainfrom
mobuchowski merged 1 commit intoapache:mainfrom
Conversation
kacpermuda
force-pushed
the
fix-ol-warning-duplicate
branch
from
dfdea45 to
20aaaec
Compare
mobuchowski
approved these changes
May 8, 2025
Contributor
mobuchowski
left a comment
mobuchowski
left a comment
There was a problem hiding this comment.
Approved with one nit
providers/openlineage/src/airflow/providers/openlineage/extractors/base.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the scenario when Operator's OL method is returning None explicitly and not as a result of failure, we should not be logging the Exception on the warning level, as OL is the source of this exception. Missed that case when refactored it recently.
This is how it looks like now:
After the fix, only second warning will be displayed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.